Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2177933002: Use UMA to track characteristics of dst color spaces (Closed)

Created:
4 years, 5 months ago by msarett
Modified:
4 years, 5 months ago
CC:
chromium-reviews, blink-reviews, asvitkine+watch_chromium.org, Brian Osman, mtklein_C
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use UMA to track characteristics of dst color spaces As far as I can tell, SRGB gamma and 2.2 gamma dst color spaces are very common, with all other possibilities being extremely rare. We'd like to limit our color correct implementations to approximations of SRGB and 2Dot2 destinations: (1) Allows software and gpu to stay in sync. (2) Avoids code bloat caused by supporting any arbitrary representation that can be packed into an ICC profile. To be confident in making this decision, we need some metrics to help verify our assumptions about the dst color spaces. BUG= Committed: https://crrev.com/e61d7832827e6a557a119cc7601821c5fb37bca2 Cr-Commit-Position: refs/heads/master@{#407675}

Patch Set 1 #

Patch Set 2 : Reverse 'if' logic #

Patch Set 3 : Refactor #

Total comments: 4

Patch Set 4 : Fix include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -0 lines) Patch
M third_party/WebKit/Source/platform/graphics/BitmapImageMetrics.h View 1 2 3 2 chunks +14 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/BitmapImageMetrics.cpp View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 2 chunks +14 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 20 (11 generated)
msarett
Please take a look. fmalita@ third_party/WebKit/Source/platform/ holte@ tools/metrics/histograms/histograms.xml
4 years, 5 months ago (2016-07-25 15:49:21 UTC) #5
f(malita)
https://codereview.chromium.org/2177933002/diff/60001/third_party/WebKit/Source/platform/graphics/BitmapImageMetrics.h File third_party/WebKit/Source/platform/graphics/BitmapImageMetrics.h (right): https://codereview.chromium.org/2177933002/diff/60001/third_party/WebKit/Source/platform/graphics/BitmapImageMetrics.h#newcode8 third_party/WebKit/Source/platform/graphics/BitmapImageMetrics.h:8: #include "SkColorSpace.h" third_party/skia/include/core/SkColorSpace.h https://codereview.chromium.org/2177933002/diff/60001/third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp (right): https://codereview.chromium.org/2177933002/diff/60001/third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp#newcode320 third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp:320: ...
4 years, 5 months ago (2016-07-25 16:13:54 UTC) #6
msarett
https://codereview.chromium.org/2177933002/diff/60001/third_party/WebKit/Source/platform/graphics/BitmapImageMetrics.h File third_party/WebKit/Source/platform/graphics/BitmapImageMetrics.h (right): https://codereview.chromium.org/2177933002/diff/60001/third_party/WebKit/Source/platform/graphics/BitmapImageMetrics.h#newcode8 third_party/WebKit/Source/platform/graphics/BitmapImageMetrics.h:8: #include "SkColorSpace.h" On 2016/07/25 16:13:54, f(malita) wrote: > third_party/skia/include/core/SkColorSpace.h ...
4 years, 5 months ago (2016-07-25 16:50:52 UTC) #7
f(malita)
lgtm
4 years, 5 months ago (2016-07-25 17:12:11 UTC) #8
Steven Holte
lgtm
4 years, 5 months ago (2016-07-25 19:06:30 UTC) #9
msarett
4 years, 5 months ago (2016-07-25 20:53:03 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2177933002/80001
4 years, 5 months ago (2016-07-26 01:27:51 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:80001)
4 years, 5 months ago (2016-07-26 01:32:46 UTC) #18
commit-bot: I haz the power
4 years, 5 months ago (2016-07-26 01:34:34 UTC) #20
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/e61d7832827e6a557a119cc7601821c5fb37bca2
Cr-Commit-Position: refs/heads/master@{#407675}

Powered by Google App Engine
This is Rietveld 408576698