Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2188663003: Add plumbing for passing stats from calls to ProofSource::GetProof through QUIC. These stats are n… (Closed)

Created:
4 years, 4 months ago by Ryan Hamilton
Modified:
4 years, 4 months ago
Reviewers:
Zhongyi Shi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@128459519
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add plumbing for passing stats from calls to ProofSource::GetProof through QUIC. These stats are not yet populated. Merge internal change: 128466946 BUG=

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -45 lines) Patch
M net/quic/crypto/crypto_server_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/crypto/proof_source.h View 2 chunks +14 lines, -1 line 2 comments Download
M net/quic/crypto/proof_source_chromium.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/crypto/proof_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/crypto/quic_crypto_server_config.h View 4 chunks +7 lines, -3 lines 0 comments Download
M net/quic/crypto/quic_crypto_server_config.cc View 17 chunks +47 lines, -24 lines 0 comments Download
M net/quic/quic_crypto_server_stream.h View 3 chunks +5 lines, -2 lines 0 comments Download
M net/quic/quic_crypto_server_stream.cc View 4 chunks +10 lines, -5 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils_test.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/tools/quic/stateless_rejector.cc View 1 chunk +3 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 2192633002 Patch 20001

Messages

Total messages: 4 (1 generated)
Ryan Hamilton
4 years, 4 months ago (2016-07-27 21:32:47 UTC) #2
Zhongyi Shi
lgtm https://codereview.chromium.org/2188663003/diff/20001/net/quic/crypto/proof_source.h File net/quic/crypto/proof_source.h (right): https://codereview.chromium.org/2188663003/diff/20001/net/quic/crypto/proof_source.h#newcode41 net/quic/crypto/proof_source.h:41: class Details { nit: You might need to ...
4 years, 4 months ago (2016-07-27 21:47:55 UTC) #3
Ryan Hamilton
4 years, 4 months ago (2016-07-27 22:17:47 UTC) #4 
https://codereview.chromium.org/2188663003/diff/20001/net/quic/crypto/proof_s...
File net/quic/crypto/proof_source.h (right):

https://codereview.chromium.org/2188663003/diff/20001/net/quic/crypto/proof_s...
net/quic/crypto/proof_source.h:41: class Details {
On 2016/07/27 21:47:55, Zhongyi Shi wrote:
> nit: You might need to add the NET_EXPORT_PRIVATE for this new class.

*nod* Depends on if it's used in the tests. I'll fix in final if it's required.

Powered by Google App Engine
This is Rietveld 408576698