Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Unified Diff: net/quic/crypto/quic_crypto_server_config.h

Issue 2188663003: Add plumbing for passing stats from calls to ProofSource::GetProof through QUIC. These stats are n… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@128459519
Patch Set: Rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/crypto/quic_crypto_server_config.h
diff --git a/net/quic/crypto/quic_crypto_server_config.h b/net/quic/crypto/quic_crypto_server_config.h
index 159a9ca3417ebc37bbf622fea1f06634438605f7..5ac8cdde17697ca46e64653636cba5737cbbf34d 100644
--- a/net/quic/crypto/quic_crypto_server_config.h
+++ b/net/quic/crypto/quic_crypto_server_config.h
@@ -105,11 +105,12 @@ class NET_EXPORT_PRIVATE ValidateClientHelloResultCallback {
ValidateClientHelloResultCallback();
virtual ~ValidateClientHelloResultCallback();
- void Run(const Result* result);
+ void Run(const Result* result, std::unique_ptr<ProofSource::Details> details);
protected:
virtual void RunImpl(const CryptoHandshakeMessage& client_hello,
- const Result& result) = 0;
+ const Result& result,
+ std::unique_ptr<ProofSource::Details> details) = 0;
private:
DISALLOW_COPY_AND_ASSIGN(ValidateClientHelloResultCallback);
@@ -532,6 +533,7 @@ class NET_EXPORT_PRIVATE QuicCryptoServerConfig {
scoped_refptr<Config> requested_config,
scoped_refptr<Config> primary_config,
QuicCryptoProof* crypto_proof,
+ std::unique_ptr<ProofSource::Details> proof_source_details,
bool get_proof_failed,
ValidateClientHelloResultCallback::Result* client_hello_state,
ValidateClientHelloResultCallback* done_cb) const;
@@ -665,7 +667,8 @@ class NET_EXPORT_PRIVATE QuicCryptoServerConfig {
void Run(bool ok,
const scoped_refptr<ProofSource::Chain>& chain,
const std::string& signature,
- const std::string& leaf_cert_sct) override;
+ const std::string& leaf_cert_sct,
+ std::unique_ptr<ProofSource::Details> details) override;
private:
const QuicCryptoServerConfig* config_;
@@ -693,6 +696,7 @@ class NET_EXPORT_PRIVATE QuicCryptoServerConfig {
const scoped_refptr<ProofSource::Chain>& chain,
const std::string& signature,
const std::string& leaf_cert_sct,
+ std::unique_ptr<ProofSource::Details> details,
CryptoHandshakeMessage message,
std::unique_ptr<BuildServerConfigUpdateMessageResultCallback> cb) const;

Powered by Google App Engine
This is Rietveld 408576698