Add plumbing for passing stats from calls to ProofSource::GetProof through QUIC. These stats are n…

net/quic/crypto/proof_source.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_QUIC_CRYPTO_PROOF_SOURCE_H_
 #define NET_QUIC_CRYPTO_PROOF_SOURCE_H_
 
 #include <memory>
 #include <string>
 #include <vector>
@@ skipping 18 matching lines @@
     const std::vector<std::string> certs;
 
    private:
     friend class base::RefCounted<Chain>;
 
     virtual ~Chain();
 
     DISALLOW_COPY_AND_ASSIGN(Chain);
   };
 
+  // Details is an abstract class which acts as a container for any
+  // implementation-specific details that a ProofSource wants to return.
+  class Details {

[Zhongyi Shi, 2016/07/27 21:47:55]

nit: You might need to add the NET_EXPORT_PRIVATE for this new class.

[Ryan Hamilton, 2016/07/27 22:17:46]

*nod* Depends on if it's used in the tests. I'll fix in final if it's required.

+   public:
+    virtual ~Details() {}
+  };
+
   // Callback base class for receiving the results of an async call to GetProof.
   class Callback {
    public:
     Callback() {}
     virtual ~Callback() {}
 
     // Invoked upon completion of GetProof.
     //
     // |ok| indicates whether the operation completed successfully.  If false,
     // the values of the remaining three arguments are undefined.
     //
     // |chain| is a reference-counted pointer to an object representing the
     // certificate chain.
     //
     // |signature| contains the signature of the server config.
     //
     // |leaf_cert_sct| holds the signed timestamp (RFC6962) of the leaf cert.
+    //
+    // |details| holds a pointer to an object representing the statistics, if
+    // any,
+    // gathered during the operation of GetProof.  If no stats are available,
+    // this will be nullptr.
     virtual void Run(bool ok,
                      const scoped_refptr<Chain>& chain,
                      const std::string& signature,
-                     const std::string& leaf_cert_sct) = 0;
+                     const std::string& leaf_cert_sct,
+                     std::unique_ptr<Details> details) = 0;
 
    private:
     Callback(const Callback&) = delete;
     Callback& operator=(const Callback&) = delete;
   };
 
   virtual ~ProofSource() {}
 
   // GetProof finds a certificate chain for |hostname|, sets |out_chain| to
   // point to it (in leaf-first order), calculates a signature of
@@ skipping 49 matching lines @@
                         const std::string& server_config,
                         QuicVersion quic_version,
                         base::StringPiece chlo_hash,
                         bool ecdsa_ok,
                         std::unique_ptr<Callback> callback) = 0;
 };
 
 }  // namespace net
 
 #endif  // NET_QUIC_CRYPTO_PROOF_SOURCE_H_