Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2188633003: Expose more gamma info for UMA statistics (Closed)

Created:
4 years, 4 months ago by msarett
Modified:
4 years, 4 months ago
Reviewers:
Brian Osman, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add enums to SkColorSpace::GammaNamed #

Patch Set 3 : v3 #

Patch Set 4 : Track invalid gamma as well #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -12 lines) Patch
M include/core/SkColorSpace.h View 1 2 3 2 chunks +15 lines, -2 lines 0 comments Download
M src/core/SkColorSpace.cpp View 1 2 1 chunk +38 lines, -0 lines 0 comments Download
M src/core/SkColorSpace_ICC.cpp View 1 2 3 4 chunks +12 lines, -10 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 23 (16 generated)
msarett
4 years, 4 months ago (2016-07-27 18:28:56 UTC) #6
msarett
Wrote a new version. Not sure I like it.
4 years, 4 months ago (2016-07-27 19:24:07 UTC) #7
msarett
This one is the winner.
4 years, 4 months ago (2016-07-27 19:51:48 UTC) #13
msarett
Store invalid gamma in a separate enum.
4 years, 4 months ago (2016-07-27 20:02:54 UTC) #14
mtklein
lgtm
4 years, 4 months ago (2016-07-27 20:08:35 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2188633003/120001
4 years, 4 months ago (2016-07-27 20:50:53 UTC) #21
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 20:51:49 UTC) #23
Message was sent while issue was closed.
Committed patchset #4 (id:120001) as
https://skia.googlesource.com/skia/+/7b9b541af8a0deb0da33a7979f1a904f42db63d1

Powered by Google App Engine
This is Rietveld 408576698