Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(907)

Unified Diff: include/core/SkColorSpace.h

Issue 2188633003: Expose more gamma info for UMA statistics (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Track invalid gamma as well Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/core/SkColorSpace.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/core/SkColorSpace.h
diff --git a/include/core/SkColorSpace.h b/include/core/SkColorSpace.h
index 57f74e985d9a732b0d6416046cb13ed1b003249f..2bf2ed0de6ded1088048690d29952f0dae1bd75c 100644
--- a/include/core/SkColorSpace.h
+++ b/include/core/SkColorSpace.h
@@ -42,10 +42,14 @@ public:
/**
* Gamma is represented by a look-up table, a parametric curve, or an uncommon
- * exponential curve. Or there is an additional pre-processing step before the
- * applying the gamma.
+ * exponential curve. Or the R, G, and B gammas do not match.
*/
kNonStandard_GammaNamed,
+
+ /**
+ * To be used by UMA code only. ICC profiles lacks valid gamma representation.
+ */
+ kInvalid_GammaNamed,
};
/**
@@ -78,6 +82,15 @@ public:
}
/**
+ * To be used only by UMA code.
+ */
+ bool gammasAreMatching() const;
+ bool gammasAreNamed() const;
+ bool gammasAreValues() const;
+ bool gammasAreTables() const;
+ bool gammasAreParams() const;
+
+ /**
* Returns nullptr on failure. Fails when we fallback to serializing ICC data and
* the data is too large to serialize.
*/
« no previous file with comments | « no previous file | src/core/SkColorSpace.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698