Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Issue 2187613003: Revert of [gn] Don't use PIE for host executables (Closed)

Created:
4 years, 4 months ago by Michael Hablich
Modified:
4 years, 4 months ago
CC:
oth, ghost stip (do not use), v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [gn] Don't use PIE for host executables (patchset #2 id:20001 of https://codereview.chromium.org/2179303003/ ) Reason for revert: Breaks roll: https://codereview.chromium.org/2182043004/ Original issue's description: > [gn] Don't use PIE for host executables > > Using PIE switches on ASLR. With mksnapshot, this can lead > to non-deterministic snapshots. > > BUG=v8:5233 > > Committed: https://crrev.com/4ca39b53245619d94a80a93939613774e68e4649 > Cr-Commit-Position: refs/heads/master@{#38084} TBR=jochen@chromium.org,vogelheim@chromium.org,yangguo@chromium.org,machenbach@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5233 Committed: https://crrev.com/45b5019705a2aaeaa99a859acf38a033ea0d6766 Cr-Commit-Position: refs/heads/master@{#38092}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -16 lines) Patch
M BUILD.gn View 2 chunks +0 lines, -6 lines 0 comments Download
M gni/v8.gni View 1 chunk +4 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Hablich
Created Revert of [gn] Don't use PIE for host executables
4 years, 4 months ago (2016-07-27 11:43:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2187613003/1
4 years, 4 months ago (2016-07-27 11:43:39 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-27 11:43:45 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/45b5019705a2aaeaa99a859acf38a033ea0d6766 Cr-Commit-Position: refs/heads/master@{#38092}
4 years, 4 months ago (2016-07-27 11:45:07 UTC) #6
Michael Achenbach
4 years, 4 months ago (2016-07-27 12:25:22 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698