Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Unified Diff: BUILD.gn

Issue 2187613003: Revert of [gn] Don't use PIE for host executables (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gni/v8.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 67ec024242578befb351d3a82a10af7fb742a80e..b737883542b372d4cf7e2b7aa95f6fc45b1483d3 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -2171,9 +2171,6 @@
v8_executable("mksnapshot") {
visibility = [ ":*" ] # Only targets in this file can depend on this.
- # This is executed on the host only and doesn't require PIE.
- want_pie = false
-
sources = [
"src/snapshot/mksnapshot.cc",
]
@@ -2195,9 +2192,6 @@
# table can built during build. The table depends on the properties of
# bytecodes that are described in bytecodes.{cc,h}.
visibility = [ ":*" ] # Only targets in this file can depend on this.
-
- # This is executed on the host only and doesn't require PIE.
- want_pie = false
sources = [
"src/interpreter/bytecode-peephole-optimizer.h",
« no previous file with comments | « no previous file | gni/v8.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698