Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(877)

Unified Diff: gni/v8.gni

Issue 2187613003: Revert of [gn] Don't use PIE for host executables (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gni/v8.gni
diff --git a/gni/v8.gni b/gni/v8.gni
index 3ed3c25bc8edfd6105a85b125dcf3fe0bd464ee3..5aac4e333a26feae5cb10c2551f8f24b3a260f6d 100644
--- a/gni/v8.gni
+++ b/gni/v8.gni
@@ -87,19 +87,13 @@
template("v8_executable") {
executable(target_name) {
- forward_variables_from(invoker, "*", [ "configs", "want_pie"])
+ forward_variables_from(invoker, "*", [ "configs" ])
configs += invoker.configs
configs -= v8_remove_configs
configs += v8_add_configs
- if (!defined(invoker.want_pie) || invoker.want_pie) {
- if (is_linux) {
- # For enabling ASLR.
- ldflags = [ "-pie" ]
- }
- } else {
- if (is_android) {
- configs -= "//build/config/android:executable_config"
- }
+ if (is_linux) {
+ # For enabling ASLR.
+ ldflags = [ "-pie" ]
}
}
}
« no previous file with comments | « BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698