Make normal MD text buttons *on infobars* white.

Make normal MD text buttons *on infobars* white.

This is a second attempt to fix the infobar button color. The first
attempt was 886005cc219 but that broke the download shelf (particularly
noticeable in incognito).

This fix is a bandaid in that we should rely on the native theme. However
that is difficult right now because we can't use ButtonBackgroundColor
until all buttons are MD.

Being able to set a custom bg color will also be useful for
crbug.com/617478

BUG=629658
Committed: https://crrev.com/032442dec365358e954842c326bc7b1f37397805
Cr-Commit-Position: refs/heads/master@{#407986}

[Evan Stade, 2016-07-26 22:11:22]

Description was changed from

==========
Make normal MD text buttons *on infobars* white.

This is a second attempt to fix the infobar button color. The first
attempt was 886005cc219 but that broke the download shelf (particularly
noticeable in incognito).

This fix is a bandaid in that we should rely on the theme engine. However
that is difficult right now because we can't use ButtonBackgroundColor
until all buttons are MD.

Being able to set a custom bg color will also be useful for
crbug.com/617478

BUG=629658
==========

to

==========
Make normal MD text buttons *on infobars* white.

This is a second attempt to fix the infobar button color. The first
attempt was 886005cc219 but that broke the download shelf (particularly
noticeable in incognito).

This fix is a bandaid in that we should rely on the native theme. However
that is difficult right now because we can't use ButtonBackgroundColor
until all buttons are MD.

Being able to set a custom bg color will also be useful for
crbug.com/617478

BUG=629658
==========

[Evan Stade, 2016-07-26 22:12:13]

estade@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2016-07-26 23:27:27]

LGTM

https://codereview.chromium.org/2187473004/diff/1/ui/views/controls/button/md...
File ui/views/controls/button/md_text_button.cc (right):

https://codereview.chromium.org/2187473004/diff/1/ui/views/controls/button/md...
ui/views/controls/button/md_text_button.cc:263: bg_color_override_
I'm happy you found a way to make this more impenetrable! :)

[Evan Stade, 2016-07-26 23:29:56]

https://codereview.chromium.org/2187473004/diff/1/ui/views/controls/button/md...
File ui/views/controls/button/md_text_button.cc (right):

https://codereview.chromium.org/2187473004/diff/1/ui/views/controls/button/md...
ui/views/controls/button/md_text_button.cc:263: bg_color_override_
On 2016/07/26 23:27:27, sky wrote:
> I'm happy you found a way to make this more impenetrable! :)

I heard you like ternaries!

Personally I think this is as easy to read as if/else if/else if/else but if you
dislike it I can change it.

[Evan Stade, 2016-07-26 23:30:05]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 23:30:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2016-07-26 23:44:14]

While I would have gone with if/else there are others that like
ternaries. It's one of those personal preference things, so leave it.
This is why I approved it earlier.

  -Scott

On Tue, Jul 26, 2016 at 4:29 PM,  <estade@chromium.org> wrote:
>
>
https://codereview.chromium.org/2187473004/diff/1/ui/views/controls/button/md...
> File ui/views/controls/button/md_text_button.cc (right):
>
>
https://codereview.chromium.org/2187473004/diff/1/ui/views/controls/button/md...
> ui/views/controls/button/md_text_button.cc:263: bg_color_override_
> On 2016/07/26 23:27:27, sky wrote:
>> I'm happy you found a way to make this more impenetrable! :)
>
> I heard you like ternaries!
>
> Personally I think this is as easy to read as if/else if/else if/else
> but if you dislike it I can change it.
>
> https://codereview.chromium.org/2187473004/

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Evan Stade, 2016-07-26 23:46:04]

The CQ bit was unchecked by estade@chromium.org

[Evan Stade, 2016-07-26 23:46:08]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2016-07-26 23:46:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 00:24:54]

Description was changed from

==========
Make normal MD text buttons *on infobars* white.

This is a second attempt to fix the infobar button color. The first
attempt was 886005cc219 but that broke the download shelf (particularly
noticeable in incognito).

This fix is a bandaid in that we should rely on the native theme. However
that is difficult right now because we can't use ButtonBackgroundColor
until all buttons are MD.

Being able to set a custom bg color will also be useful for
crbug.com/617478

BUG=629658
==========

to

==========
Make normal MD text buttons *on infobars* white.

This is a second attempt to fix the infobar button color. The first
attempt was 886005cc219 but that broke the download shelf (particularly
noticeable in incognito).

This fix is a bandaid in that we should rely on the native theme. However
that is difficult right now because we can't use ButtonBackgroundColor
until all buttons are MD.

Being able to set a custom bg color will also be useful for
crbug.com/617478

BUG=629658
==========

[commit-bot: I haz the power, 2016-07-27 00:24:54]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-27 00:26:20]

Description was changed from

==========
Make normal MD text buttons *on infobars* white.

This is a second attempt to fix the infobar button color. The first
attempt was 886005cc219 but that broke the download shelf (particularly
noticeable in incognito).

This fix is a bandaid in that we should rely on the native theme. However
that is difficult right now because we can't use ButtonBackgroundColor
until all buttons are MD.

Being able to set a custom bg color will also be useful for
crbug.com/617478

BUG=629658
==========

to

==========
Make normal MD text buttons *on infobars* white.

This is a second attempt to fix the infobar button color. The first
attempt was 886005cc219 but that broke the download shelf (particularly
noticeable in incognito).

This fix is a bandaid in that we should rely on the native theme. However
that is difficult right now because we can't use ButtonBackgroundColor
until all buttons are MD.

Being able to set a custom bg color will also be useful for
crbug.com/617478

BUG=629658

Committed: https://crrev.com/032442dec365358e954842c326bc7b1f37397805
Cr-Commit-Position: refs/heads/master@{#407986}
==========

[commit-bot: I haz the power, 2016-07-27 00:26:21]

Patchset 1 (id:??) landed as
https://crrev.com/032442dec365358e954842c326bc7b1f37397805
Cr-Commit-Position: refs/heads/master@{#407986}