Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3320)

Unified Diff: chrome/browser/ui/views/infobars/infobar_view.cc

Issue 2187473004: Make normal MD text buttons *on infobars* white. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/infobars/infobar_view.cc
diff --git a/chrome/browser/ui/views/infobars/infobar_view.cc b/chrome/browser/ui/views/infobars/infobar_view.cc
index 61bff73699b851db389a49096dc953b0617e3b6e..134495dd2e15461e89ff5e796eb0b4716188af26 100644
--- a/chrome/browser/ui/views/infobars/infobar_view.cc
+++ b/chrome/browser/ui/views/infobars/infobar_view.cc
@@ -64,7 +64,7 @@ const gfx::FontList& GetFontList() {
: ui::ResourceBundle::MediumFont);
}
-SkColor GetInfobarTextColor() {
+constexpr SkColor GetInfobarTextColor() {
return SK_ColorBLACK;
}
@@ -76,6 +76,7 @@ SkColor GetInfobarTextColor() {
// static
const int InfoBarView::kButtonButtonSpacing = views::kRelatedButtonHSpacing;
const int InfoBarView::kEndOfLabelSpacing = views::kItemLabelSpacing;
+const SkColor InfoBarView::kTextColor = GetInfobarTextColor();
InfoBarView::InfoBarView(std::unique_ptr<infobars::InfoBarDelegate> delegate)
: infobars::InfoBar(std::move(delegate)),
@@ -167,17 +168,6 @@ views::LabelButton* InfoBarView::CreateTextButton(
return button;
}
-views::MdTextButton* InfoBarView::CreateMdTextButton(
- views::ButtonListener* listener,
- const base::string16& text) {
- DCHECK(ui::MaterialDesignController::IsModeMaterial());
- views::MdTextButton* button =
- views::MdTextButton::CreateMdButton(listener, text);
- // TODO(estade): can we just remove this?
- button->SetEnabledTextColors(GetInfobarTextColor());
- return button;
-}
-
// static
void InfoBarView::AssignWidths(Labels* labels, int available_width) {
std::sort(labels->begin(), labels->end(), SortLabelsByDecreasingWidth);

Powered by Google App Engine
This is Rietveld 408576698