Make normal MD text buttons *on infobars* white.

ui/views/controls/button/md_text_button.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/button/md_text_button.h"
 
 #include "base/i18n/case_conversion.h"
 #include "ui/base/material_design/material_design_controller.h"
 #include "ui/gfx/canvas.h"
 #include "ui/gfx/color_utils.h"
@@ skipping 236 matching lines @@
       bottom_padding - inbuilt_bottom_padding, kHorizontalPadding));
 }
 
 MdTextButton::~MdTextButton() {}
 
 void MdTextButton::UpdateColors() {
   ui::NativeTheme::ColorId fg_color_id =
       is_cta_ ? ui::NativeTheme::kColorId_TextOnCallToActionColor
               : ui::NativeTheme::kColorId_ButtonEnabledColor;
 
-  // When there's no call to action, respect a color override if one has
-  // been set. For call to action styling, don't let individual buttons
-  // specify a color.
   ui::NativeTheme* theme = GetNativeTheme();
-  if (is_cta_ || !explicitly_set_normal_color())
+  if (!explicitly_set_normal_color())
     LabelButton::SetEnabledTextColors(theme->GetSystemColor(fg_color_id));
 
   SkColor text_color = label()->enabled_color();
   SkColor bg_color =
-      is_cta_
-          ? theme->GetSystemColor(ui::NativeTheme::kColorId_CallToActionColor)
-          : is_default()
-                ? color_utils::BlendTowardOppositeLuma(text_color, 0xD8)
-                : SK_ColorWHITE;
+      bg_color_override_

[sky, 2016/07/26 23:27:27]

I'm happy you found a way to make this more impenetrable! :)

[Evan Stade, 2016/07/26 23:29:56]

I heard you like ternaries!

Personally I think this is as easy to read as if/else if/else if/else but if you
dislike it I can change it.

+          ? *bg_color_override_
+          : is_cta_
+                ? theme->GetSystemColor(
+                      ui::NativeTheme::kColorId_CallToActionColor)
+                : is_default()
+                      ? color_utils::BlendTowardOppositeLuma(text_color, 0xD8)
+                      : SK_ColorTRANSPARENT;
 
   const SkAlpha kStrokeOpacity = 0x1A;
   SkColor stroke_color = (is_cta_ || color_utils::IsDark(text_color))
                              ? SkColorSetA(SK_ColorBLACK, kStrokeOpacity)
                              : SkColorSetA(SK_ColorWHITE, 2 * kStrokeOpacity);
 
   set_background(Background::CreateBackgroundPainter(
       true, Painter::CreateRoundRectWith1PxBorderPainter(
                 bg_color, stroke_color, kInkDropSmallCornerRadius)));
 }
 
 }  // namespace views