added support for push_constant layout

added support for push_constant layout

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2187433003

Committed: https://skia.googlesource.com/skia/+/fa5f65ac61fd525029aa9dab161ffe4896c10f6d
Committed: https://skia.googlesource.com/skia/+/8ac838d978578c44b75a801489c985e5284dd66f

[ethannicholas, 2016-07-26 19:05:04]

Description was changed from

==========
added support for push_constant layout

BUG=skia:
==========

to

==========
added support for push_constant layout

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2187433003
==========

[ethannicholas, 2016-11-14 18:10:50]

ethannicholas@google.com changed reviewers:
+ egdaniel@google.com

[ethannicholas, 2016-11-14 18:10:51]

setTestingLevel("Hmm. Doesn't seem to crash, at least.");

Enjoy!

[egdaniel, 2016-11-14 18:48:35]

https://codereview.chromium.org/2187433003/diff/20001/src/sksl/SkSLMemoryLayo...
File src/sksl/SkSLMemoryLayout.h (right):

https://codereview.chromium.org/2187433003/diff/20001/src/sksl/SkSLMemoryLayo...
src/sksl/SkSLMemoryLayout.h:57: case Type::kStruct_Kind: {
Add return here for struct. Also struct must be rounded to multiple of 16 for
140 but not 430. In the bellow code for 140, are we just assuming nothing will
have an alignment of say 20?

https://codereview.chromium.org/2187433003/diff/20001/src/sksl/SkSLSPIRVCodeG...
File src/sksl/SkSLSPIRVCodeGenerator.cpp (right):

https://codereview.chromium.org/2187433003/diff/20001/src/sksl/SkSLSPIRVCodeG...
src/sksl/SkSLSPIRVCodeGenerator.cpp:2438: (SpvId)
fDefaultLayout.stride(var->fType),
extra whitespace

https://codereview.chromium.org/2187433003/diff/20001/src/sksl/ir/SkSLLayout.h
File src/sksl/ir/SkSLLayout.h (right):

https://codereview.chromium.org/2187433003/diff/20001/src/sksl/ir/SkSLLayout....
src/sksl/ir/SkSLLayout.h:77: if (fBlendSupportAllEquations) {
dupe of the line above?

[egdaniel, 2016-11-15 15:31:19]

would you also hate me if I said your tests should be in yoda....

https://codereview.chromium.org/2187433003/diff/80001/src/sksl/SkSLMemoryLayo...
File src/sksl/SkSLMemoryLayout.h (right):

https://codereview.chromium.org/2187433003/diff/80001/src/sksl/SkSLMemoryLayo...
src/sksl/SkSLMemoryLayout.h:33: size_t roundArraySize(size_t raw) const {
Lets give this a more generic name since we use it for structs as well. Also
update comment.

https://codereview.chromium.org/2187433003/diff/80001/src/sksl/SkSLMemoryLayo...
src/sksl/SkSLMemoryLayout.h:114: size_t alignment = this->alignment(type);
add my totally insane assert :)

https://codereview.chromium.org/2187433003/diff/80001/tests/SkSLMemoryLayoutT...
File tests/SkSLMemoryLayoutTest.cpp (right):

https://codereview.chromium.org/2187433003/diff/80001/tests/SkSLMemoryLayoutT...
tests/SkSLMemoryLayoutTest.cpp:27: REPORTER_ASSERT(r,
layout.size(*context.fIVec4_Type) == 16);
Add mats to this

[egdaniel, 2016-11-15 16:59:28]

lgtm with just two more minor things

https://codereview.chromium.org/2187433003/diff/100001/src/sksl/SkSLMemoryLay...
File src/sksl/SkSLMemoryLayout.h (right):

https://codereview.chromium.org/2187433003/diff/100001/src/sksl/SkSLMemoryLay...
src/sksl/SkSLMemoryLayout.h:116: ASSERT(0 == alignment %
this->alignment(*type.fields()[0].fType));
Hmm this does risk referencing field 0 if there a struct with no fields at all
(unless that is checked elsewhere already).

https://codereview.chromium.org/2187433003/diff/100001/tests/SkSLMemoryLayout...
File tests/SkSLMemoryLayoutTest.cpp (right):

https://codereview.chromium.org/2187433003/diff/100001/tests/SkSLMemoryLayout...
tests/SkSLMemoryLayoutTest.cpp:103: REPORTER_ASSERT(r, 32 ==
layout.size(*context.fMat2x4_Type));
I think I would just have 2x2, 3x3, and 4x4 since that is what we use, but it
really doesn't matter.

Regardless, I would have these in the 140 as well so it shows the difference in
the two.

[ethannicholas, 2016-11-15 17:36:54]

Patchset #7 (id:120001) has been deleted

[ethannicholas, 2016-11-15 19:03:00]

The CQ bit was checked by ethannicholas@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-15 19:03:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 19:27:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 19:27:17]

Dry run: Try jobs failed on following builders:
  Test-Android-Clang-Nexus5-GPU-Adreno330-arm-Release-GN_Android-Trybot on
master.client.skia.android (JOB_FAILED,
http://build.chromium.org/p/client.skia.android/builders/Test-Android-Clang-N...)

[ethannicholas, 2016-11-15 20:51:41]

The CQ bit was checked by ethannicholas@google.com

[ethannicholas, 2016-11-15 20:51:42]

The patchset sent to the CQ was uploaded after l-g-t-m from egdaniel@google.com
Link to the patchset: https://codereview.chromium.org/2187433003/#ps140001
(title: "added some more tests")

[commit-bot: I haz the power, 2016-11-15 20:51:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 20:53:09]

Description was changed from

==========
added support for push_constant layout

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2187433003
==========

to

==========
added support for push_constant layout

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2187433003

Committed:
https://skia.googlesource.com/skia/+/fa5f65ac61fd525029aa9dab161ffe4896c10f6d
==========

[commit-bot: I haz the power, 2016-11-15 20:53:10]

Committed patchset #7 (id:140001) as
https://skia.googlesource.com/skia/+/fa5f65ac61fd525029aa9dab161ffe4896c10f6d

[egdaniel, 2016-11-16 14:02:40]

A revert of this CL (patchset #7 id:140001) has been created in
https://codereview.chromium.org/2509673002/ by egdaniel@google.com.

The reason for reverting is: hitting assert in vulkan.

[mtklein_C, 2016-11-16 15:22:26]

On 2016/11/16 at 14:02:40, egdaniel wrote:
> A revert of this CL (patchset #7 id:140001) has been created in
https://codereview.chromium.org/2509673002/ by egdaniel@google.com.
> 
> The reason for reverting is: hitting assert in vulkan.

Please do figure out how to revert this.  The -ASAN bot is failing (use after
free) as is the -TSAN bot (race on the creation of some static I think).

[mtklein_C, 2016-11-16 15:24:06]

On 2016/11/16 at 15:22:26, mtklein_C wrote:
> On 2016/11/16 at 14:02:40, egdaniel wrote:
> > A revert of this CL (patchset #7 id:140001) has been created in
https://codereview.chromium.org/2509673002/ by egdaniel@google.com.
> > 
> > The reason for reverting is: hitting assert in vulkan.
> 
> Please do figure out how to revert this.  The -ASAN bot is failing (use after
free) as is the -TSAN bot (race on the creation of some static I think).

...and it's breaking the Google3 roll.

[egdaniel, 2016-11-16 15:30:05]

On 2016/11/16 15:24:06, mtklein_C wrote:
> On 2016/11/16 at 15:22:26, mtklein_C wrote:
> > On 2016/11/16 at 14:02:40, egdaniel wrote:
> > > A revert of this CL (patchset #7 id:140001) has been created in
> https://codereview.chromium.org/2509673002/ by mailto:egdaniel@google.com.
> > > 
> > > The reason for reverting is: hitting assert in vulkan.
> > 
> > Please do figure out how to revert this.  The -ASAN bot is failing (use
after
> free) as is the -TSAN bot (race on the creation of some static I think).
> 
> ...and it's breaking the Google3 roll.

revert hopefully will land now

[ethannicholas, 2016-11-17 21:31:56]

Description was changed from

==========
added support for push_constant layout

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2187433003

Committed:
https://skia.googlesource.com/skia/+/fa5f65ac61fd525029aa9dab161ffe4896c10f6d
==========

to

==========
added support for push_constant layout

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2187433003

Committed:
https://skia.googlesource.com/skia/+/fa5f65ac61fd525029aa9dab161ffe4896c10f6d
==========

[ethannicholas, 2016-11-17 21:54:53]

The CQ bit was checked by ethannicholas@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 21:55:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 22:41:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 22:41:49]

Dry run: This issue passed the CQ dry run.

[ethannicholas, 2016-11-21 19:02:35]

The CQ bit was checked by ethannicholas@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 19:02:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 19:38:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 19:38:38]

Dry run: This issue passed the CQ dry run.

[ethannicholas, 2016-11-22 15:10:23]

The CQ bit was checked by ethannicholas@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 15:10:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 15:14:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 15:14:21]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[ethannicholas, 2016-11-22 15:55:29]

The CQ bit was checked by ethannicholas@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 15:55:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 16:32:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 16:32:58]

Dry run: This issue passed the CQ dry run.

[ethannicholas, 2016-11-22 16:38:31]

The CQ bit was checked by ethannicholas@google.com

[ethannicholas, 2016-11-22 16:38:31]

The patchset sent to the CQ was uploaded after l-g-t-m from egdaniel@google.com
Link to the patchset: https://codereview.chromium.org/2187433003/#ps220001
(title: "rebased")

[commit-bot: I haz the power, 2016-11-22 16:38:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 16:39:36]

CQ is committing da patch.

Bot data: {"patchset_id": 220001, "attempt_start_ts": 1479832711499990,
"parent_rev": "64773e6c9f61fb319f597a8d7dd7ee377d51a43a", "commit_rev":
"8ac838d978578c44b75a801489c985e5284dd66f"}

[commit-bot: I haz the power, 2016-11-22 16:39:39]

Description was changed from

==========
added support for push_constant layout

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2187433003

Committed:
https://skia.googlesource.com/skia/+/fa5f65ac61fd525029aa9dab161ffe4896c10f6d
==========

to

==========
added support for push_constant layout

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2187433003

Committed:
https://skia.googlesource.com/skia/+/fa5f65ac61fd525029aa9dab161ffe4896c10f6d
Committed:
https://skia.googlesource.com/skia/+/8ac838d978578c44b75a801489c985e5284dd66f
==========

[commit-bot: I haz the power, 2016-11-22 16:39:40]

Committed patchset #11 (id:220001) as
https://skia.googlesource.com/skia/+/8ac838d978578c44b75a801489c985e5284dd66f

[ethannicholas, 2016-11-28 17:02:52]

Patchset #12 (id:240001) has been deleted