Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2114)

Unified Diff: content/browser/renderer_host/media/peer_connection_tracker_host.cc

Issue 2187243002: Changed raw pointer to WeakPtr to prevent use-after-free on destruction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/media/peer_connection_tracker_host.cc
diff --git a/content/browser/renderer_host/media/peer_connection_tracker_host.cc b/content/browser/renderer_host/media/peer_connection_tracker_host.cc
index 9fceb42a8b22123e8b61af89c9b3b20f9d028b25..b03152952bac3e2a94567ac074125fcf0714ada9 100644
--- a/content/browser/renderer_host/media/peer_connection_tracker_host.cc
+++ b/content/browser/renderer_host/media/peer_connection_tracker_host.cc
@@ -13,7 +13,7 @@ namespace content {
PeerConnectionTrackerHost::PeerConnectionTrackerHost(
int render_process_id,
- WebRTCEventLogHost* event_log_host)
+ const base::WeakPtr<WebRTCEventLogHost>& event_log_host)
: BrowserMessageFilter(PeerConnectionTrackerMsgStart),
render_process_id_(render_process_id),
event_log_host_(event_log_host) {
@@ -76,12 +76,14 @@ void PeerConnectionTrackerHost::OnAddPeerConnection(
info.url,
info.rtc_configuration,
info.constraints);
- event_log_host_->PeerConnectionAdded(info.lid);
+ if (event_log_host_)
+ event_log_host_->PeerConnectionAdded(info.lid);
}
void PeerConnectionTrackerHost::OnRemovePeerConnection(int lid) {
WebRTCInternals::GetInstance()->OnRemovePeerConnection(peer_pid(), lid);
- event_log_host_->PeerConnectionRemoved(lid);
+ if (event_log_host_)
+ event_log_host_->PeerConnectionRemoved(lid);
}
void PeerConnectionTrackerHost::OnUpdatePeerConnection(

Powered by Google App Engine
This is Rietveld 408576698