content/browser/renderer_host/render_process_host_impl.cc - Issue 2187243002: Changed raw pointer to WeakPtr to prevent use-after-free on destruction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_process_host_impl.cc

Issue 2187243002: Changed raw pointer to WeakPtr to prevent use-after-free on destruction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/renderer_host/render_process_host_impl.cc

diff --git a/content/browser/renderer_host/render_process_host_impl.cc b/content/browser/renderer_host/render_process_host_impl.cc

index 3a14ba69de92e115c757f4117ce040f1d704ed77..2399ff93a27525e233eedbaa99f5bf12ad78762c 100644

--- a/content/browser/renderer_host/render_process_host_impl.cc

+++ b/content/browser/renderer_host/render_process_host_impl.cc

@@ -939,8 +939,8 @@ void RenderProcessHostImpl::CreateMessageFilters() {

blob_storage_context.get()));

#if defined(ENABLE_WEBRTC)

- peer_connection_tracker_host_ =

- new PeerConnectionTrackerHost(GetID(), &webrtc_eventlog_host_);

+ peer_connection_tracker_host_ = new PeerConnectionTrackerHost(

+ GetID(), webrtc_eventlog_host_.GetWeakPtr());

AddFilter(peer_connection_tracker_host_.get());

AddFilter(new MediaStreamDispatcherHost(

GetID(), browser_context->GetResourceContext()->GetMediaDeviceIDSalt(),

« no previous file with comments | « content/browser/renderer_host/media/peer_connection_tracker_host.cc ('k') | no next file » | no next file with comments »