content/browser/renderer_host/media/peer_connection_tracker_host.h - Issue 2187243002: Changed raw pointer to WeakPtr to prevent use-after-free on destruction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/media/peer_connection_tracker_host.h

Issue 2187243002: Changed raw pointer to WeakPtr to prevent use-after-free on destruction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/media/webrtc/webrtc_eventlog_host.cc ('k') | content/browser/renderer_host/media/peer_connection_tracker_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/media/peer_connection_tracker_host.h

diff --git a/content/browser/renderer_host/media/peer_connection_tracker_host.h b/content/browser/renderer_host/media/peer_connection_tracker_host.h

index 53926f87c8191f2d1b879ac62c5a3b6b1f9ba45f..949010addeec58b80c8863bd16805adeeebd5054 100644

--- a/content/browser/renderer_host/media/peer_connection_tracker_host.h

+++ b/content/browser/renderer_host/media/peer_connection_tracker_host.h

@@ -28,8 +28,9 @@ class WebRTCEventLogHost;

class PeerConnectionTrackerHost : public BrowserMessageFilter,

public base::PowerObserver {

public:

- PeerConnectionTrackerHost(int render_process_id,

- WebRTCEventLogHost* event_log_host);

+ PeerConnectionTrackerHost(

+ int render_process_id,

+ const base::WeakPtr<WebRTCEventLogHost>& event_log_host);

// content::BrowserMessageFilter override.

bool OnMessageReceived(const IPC::Message& message) override;

@@ -60,7 +61,7 @@ class PeerConnectionTrackerHost : public BrowserMessageFilter,

int render_process_id_;

- WebRTCEventLogHost* const event_log_host_;

+ base::WeakPtr<WebRTCEventLogHost> event_log_host_;

DISALLOW_COPY_AND_ASSIGN(PeerConnectionTrackerHost);

};