Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issue 2187163002: harfbuzz-ng: make use of the use_glib gn arg (Closed)

Created:
4 years, 4 months ago by Mostyn Bramley-Moore
Modified:
4 years, 4 months ago
Reviewers:
drott
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

harfbuzz-ng: make use of the use_glib gn arg BUG=632297 Committed: https://crrev.com/923c83c5acd2bd5801c670dda6e87e1b0ec2778e Cr-Commit-Position: refs/heads/master@{#408370}

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove unnecessary use_glib #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M third_party/harfbuzz-ng/BUILD.gn View 1 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 20 (12 generated)
Mostyn Bramley-Moore
@drott: please take a look at this GN cleanup.
4 years, 4 months ago (2016-07-27 22:21:12 UTC) #4
drott
On 2016/07/27 at 22:21:12, mostynb wrote: > @drott: please take a look at this GN ...
4 years, 4 months ago (2016-07-28 07:45:16 UTC) #7
drott
https://codereview.chromium.org/2187163002/diff/1/third_party/harfbuzz-ng/BUILD.gn File third_party/harfbuzz-ng/BUILD.gn (right): https://codereview.chromium.org/2187163002/diff/1/third_party/harfbuzz-ng/BUILD.gn#newcode55 third_party/harfbuzz-ng/BUILD.gn:55: !is_component_build && use_glib) { Why is use_glib added here? ...
4 years, 4 months ago (2016-07-28 07:45:26 UTC) #8
Mostyn Bramley-Moore
> Thanks for the CL, could you describe the context and intention a bit more? ...
4 years, 4 months ago (2016-07-28 09:27:14 UTC) #10
drott
Thanks for the background, LGTM.
4 years, 4 months ago (2016-07-28 10:30:20 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2187163002/20001
4 years, 4 months ago (2016-07-28 10:32:17 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-28 10:46:21 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 10:47:43 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/923c83c5acd2bd5801c670dda6e87e1b0ec2778e
Cr-Commit-Position: refs/heads/master@{#408370}

Powered by Google App Engine
This is Rietveld 408576698