Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Side by Side Diff: third_party/harfbuzz-ng/BUILD.gn

Issue 2187163002: harfbuzz-ng: make use of the use_glib gn arg (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove unnecessary use_glib Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/chrome_build.gni") 5 import("//build/config/chrome_build.gni")
6 import("//build/config/features.gni")
6 import("//build/config/linux/pkg_config.gni") 7 import("//build/config/linux/pkg_config.gni")
7 import("//build/config/ui.gni") 8 import("//build/config/ui.gni")
8 import("//testing/libfuzzer/fuzzer_test.gni") 9 import("//testing/libfuzzer/fuzzer_test.gni")
9 10
10 declare_args() { 11 declare_args() {
11 # Blink uses a cutting-edge version of Harfbuzz; most Linux distros do not 12 # Blink uses a cutting-edge version of Harfbuzz; most Linux distros do not
12 # contain a new enough version of the code to work correctly. However, 13 # contain a new enough version of the code to work correctly. However,
13 # ChromeOS chroots (i.e, real ChromeOS builds for devices) do contain a 14 # ChromeOS chroots (i.e, real ChromeOS builds for devices) do contain a
14 # new enough version of the library, and so this variable exists so that 15 # new enough version of the library, and so this variable exists so that
15 # ChromeOS can build against the system lib and keep binary sizes smaller. 16 # ChromeOS can build against the system lib and keep binary sizes smaller.
(...skipping 174 matching lines...) Expand 10 before | Expand all | Expand 10 after
190 191
191 # When without -fvisibility=hidden for pango to use the harfbuzz 192 # When without -fvisibility=hidden for pango to use the harfbuzz
192 # in the tree, all symbols pango needs must be included, or 193 # in the tree, all symbols pango needs must be included, or
193 # pango uses mixed versions of harfbuzz and leads to crash. 194 # pango uses mixed versions of harfbuzz and leads to crash.
194 # See crbug.com/462689. 195 # See crbug.com/462689.
195 if (is_linux && use_pango && !is_chromeos && !is_official_build && 196 if (is_linux && use_pango && !is_chromeos && !is_official_build &&
196 current_cpu != "arm" && current_cpu != "mipsel") { 197 current_cpu != "arm" && current_cpu != "mipsel") {
197 deps += [ "//build/linux:freetype2" ] 198 deps += [ "//build/linux:freetype2" ]
198 configs -= [ "//build/config/gcc:symbol_visibility_hidden" ] 199 configs -= [ "//build/config/gcc:symbol_visibility_hidden" ]
199 configs += [ "//build/config/gcc:symbol_visibility_default" ] 200 configs += [ "//build/config/gcc:symbol_visibility_default" ]
200 configs += [ "//build/config/linux:glib" ]
201 sources += [ 201 sources += [
202 "src/hb-ft.cc", 202 "src/hb-ft.cc",
203 "src/hb-ft.h", 203 "src/hb-ft.h",
204 ]
205 }
206 if (use_glib) {
207 configs += [ "//build/config/linux:glib" ]
208 sources += [
204 "src/hb-glib.cc", 209 "src/hb-glib.cc",
205 "src/hb-glib.h", 210 "src/hb-glib.h",
206 ] 211 ]
207 } 212 }
208 } 213 }
209 } 214 }
210 215
211 fuzzer_test("harfbuzz_fuzzer") { 216 fuzzer_test("harfbuzz_fuzzer") {
212 sources = [ 217 sources = [
213 "fuzz/harfbuzz_fuzzer.cc", 218 "fuzz/harfbuzz_fuzzer.cc",
214 ] 219 ]
215 deps = [ 220 deps = [
216 ":harfbuzz-ng", 221 ":harfbuzz-ng",
217 ] 222 ]
218 libfuzzer_options = [ "max_len=16800" ] 223 libfuzzer_options = [ "max_len=16800" ]
219 seed_corpus = "fuzz/seed_corpus" 224 seed_corpus = "fuzz/seed_corpus"
220 } 225 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698