harfbuzz-ng: make use of the use_glib gn arg

third_party/harfbuzz-ng/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/chrome_build.gni")
+import("//build/config/features.gni")
 import("//build/config/linux/pkg_config.gni")
 import("//build/config/ui.gni")
 import("//testing/libfuzzer/fuzzer_test.gni")
 
 declare_args() {
   # Blink uses a cutting-edge version of Harfbuzz; most Linux distros do not
   # contain a new enough version of the code to work correctly. However,
   # ChromeOS chroots (i.e, real ChromeOS builds for devices) do contain a
   # new enough version of the library, and so this variable exists so that
   # ChromeOS can build against the system lib and keep binary sizes smaller.
@@ skipping 27 matching lines @@
     }
     if (is_win) {
       # Result of 32-bit shift implicitly converted to 64 bits.
       cflags += [ "/wd4334" ]
     }
   }
 
   # See also chrome/browser/ui/libgtk2ui/BUILD.gn which pulls this.
   config("pangoft2_link_hack") {
     if (is_linux && use_pango && !is_chromeos && !is_official_build &&
-        current_cpu != "arm" && current_cpu != "mipsel" && !is_component_build) {
+        current_cpu != "arm" && current_cpu != "mipsel" &&
+        !is_component_build && use_glib) {

[drott, 2016/07/28 07:45:26]

Why is use_glib added here? Because pango requires it? Perhaps moving it closer
to use_pango could make that clearer.

[Mostyn Bramley-Moore, 2016/07/28 09:27:14]

I added this here because this is dealing with a glib symbol, but this is
probably not needed- I will remove it.

       # These symbols are referenced from libpangoft2, which will be
       # dynamically linked later.
       ldflags = [ "-Wl,-uhb_ft_face_create_cached,-uhb_glib_get_unicode_funcs" ]
     }
   }
 
   static_library("harfbuzz-ng") {
     sources = [
       "src/hb-atomic-private.hh",
       "src/hb-blob.cc",
@@ skipping 126 matching lines @@
 
     # When without -fvisibility=hidden for pango to use the harfbuzz
     # in the tree, all symbols pango needs must be included, or
     # pango uses mixed versions of harfbuzz and leads to crash.
     # See crbug.com/462689.
     if (is_linux && use_pango && !is_chromeos && !is_official_build &&
         current_cpu != "arm" && current_cpu != "mipsel") {
       deps += [ "//build/linux:freetype2" ]
       configs -= [ "//build/config/gcc:symbol_visibility_hidden" ]
       configs += [ "//build/config/gcc:symbol_visibility_default" ]
-      configs += [ "//build/config/linux:glib" ]
       sources += [
         "src/hb-ft.cc",
         "src/hb-ft.h",
+      ]
+    }
+    if (use_glib) {
+      configs += [ "//build/config/linux:glib" ]
+      sources += [
         "src/hb-glib.cc",
         "src/hb-glib.h",
       ]
     }
   }
 }
 
 fuzzer_test("harfbuzz_fuzzer") {
   sources = [
     "fuzz/harfbuzz_fuzzer.cc",
   ]
   deps = [
     ":harfbuzz-ng",
   ]
   libfuzzer_options = [ "max_len=16800" ]
   seed_corpus = "fuzz/seed_corpus"
 }