Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Issue 2186933002: Revert "Disable flaky MetricsWebContentsObserverBrowserTests" (Closed)

Created:
4 years, 4 months ago by Bryan McQuade
Modified:
4 years, 4 months ago
Reviewers:
shivanisha
CC:
chromium-reviews, csharrison+watch_chromium.org, loading-reviews+metrics_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Disable flaky MetricsWebContentsObserverBrowserTests" This reverts commit 6b03f78c08072600433f7009401f0f040d22cd0a. These tests were originally flaky, but that was fixed in https://codereview.chromium.org/2176803002. Unfortunately, at the time the fix was landed, one of the bots was in a bad state, and continued to report failures despite the fix. At the time, to be conservative, we disabled these tests. The broken bot has since been fixed, so we can now re-enable these tests. BUG=630549 Committed: https://crrev.com/c0338f99bca56370f27ba0d785c2f168264a9acd Cr-Commit-Position: refs/heads/master@{#408159}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc View 3 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Bryan McQuade
PTAL
4 years, 4 months ago (2016-07-27 13:13:05 UTC) #5
shivanisha
On 2016/07/27 at 13:13:05, bmcquade wrote: > PTAL LGTM
4 years, 4 months ago (2016-07-27 16:55:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2186933002/1
4 years, 4 months ago (2016-07-27 17:01:14 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-27 17:04:30 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 17:06:45 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c0338f99bca56370f27ba0d785c2f168264a9acd
Cr-Commit-Position: refs/heads/master@{#408159}

Powered by Google App Engine
This is Rietveld 408576698