Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Side by Side Diff: chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

Issue 2186933002: Revert "Disable flaky MetricsWebContentsObserverBrowserTests" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/macros.h" 5 #include "base/macros.h"
6 #include "base/test/histogram_tester.h" 6 #include "base/test/histogram_tester.h"
7 #include "chrome/browser/page_load_metrics/observers/core_page_load_metrics_obse rver.h" 7 #include "chrome/browser/page_load_metrics/observers/core_page_load_metrics_obse rver.h"
8 #include "chrome/browser/page_load_metrics/observers/document_write_page_load_me trics_observer.h" 8 #include "chrome/browser/page_load_metrics/observers/document_write_page_load_me trics_observer.h"
9 #include "chrome/common/url_constants.h" 9 #include "chrome/common/url_constants.h"
10 #include "chrome/test/base/in_process_browser_test.h" 10 #include "chrome/test/base/in_process_browser_test.h"
(...skipping 17 matching lines...) Expand all
28 28
29 IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest, NoNavigation) { 29 IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest, NoNavigation) {
30 ASSERT_TRUE(embedded_test_server()->Start()); 30 ASSERT_TRUE(embedded_test_server()->Start());
31 31
32 histogram_tester_.ExpectTotalCount(internal::kHistogramCommit, 0); 32 histogram_tester_.ExpectTotalCount(internal::kHistogramCommit, 0);
33 histogram_tester_.ExpectTotalCount(internal::kHistogramDomContentLoaded, 0); 33 histogram_tester_.ExpectTotalCount(internal::kHistogramDomContentLoaded, 0);
34 histogram_tester_.ExpectTotalCount(internal::kHistogramLoad, 0); 34 histogram_tester_.ExpectTotalCount(internal::kHistogramLoad, 0);
35 histogram_tester_.ExpectTotalCount(internal::kHistogramFirstLayout, 0); 35 histogram_tester_.ExpectTotalCount(internal::kHistogramFirstLayout, 0);
36 } 36 }
37 37
38 IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest, 38 IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest, NewPage) {
39 DISABLED_NewPage) {
40 ASSERT_TRUE(embedded_test_server()->Start()); 39 ASSERT_TRUE(embedded_test_server()->Start());
41 40
42 ui_test_utils::NavigateToURL(browser(), 41 ui_test_utils::NavigateToURL(browser(),
43 embedded_test_server()->GetURL("/title1.html")); 42 embedded_test_server()->GetURL("/title1.html"));
44 NavigateToUntrackedUrl(); 43 NavigateToUntrackedUrl();
45 44
46 histogram_tester_.ExpectTotalCount(internal::kHistogramDomContentLoaded, 1); 45 histogram_tester_.ExpectTotalCount(internal::kHistogramDomContentLoaded, 1);
47 histogram_tester_.ExpectTotalCount(internal::kHistogramLoad, 1); 46 histogram_tester_.ExpectTotalCount(internal::kHistogramLoad, 1);
48 histogram_tester_.ExpectTotalCount(internal::kHistogramFirstLayout, 1); 47 histogram_tester_.ExpectTotalCount(internal::kHistogramFirstLayout, 1);
49 histogram_tester_.ExpectTotalCount(internal::kHistogramParseDuration, 1); 48 histogram_tester_.ExpectTotalCount(internal::kHistogramParseDuration, 1);
50 histogram_tester_.ExpectTotalCount( 49 histogram_tester_.ExpectTotalCount(
51 internal::kHistogramParseBlockedOnScriptLoad, 1); 50 internal::kHistogramParseBlockedOnScriptLoad, 1);
52 } 51 }
53 52
54 IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest, 53 IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest,
55 DISABLED_SamePageNavigation) { 54 SamePageNavigation) {
56 ASSERT_TRUE(embedded_test_server()->Start()); 55 ASSERT_TRUE(embedded_test_server()->Start());
57 56
58 ui_test_utils::NavigateToURL(browser(), 57 ui_test_utils::NavigateToURL(browser(),
59 embedded_test_server()->GetURL("/title1.html")); 58 embedded_test_server()->GetURL("/title1.html"));
60 ui_test_utils::NavigateToURL( 59 ui_test_utils::NavigateToURL(
61 browser(), embedded_test_server()->GetURL("/title1.html#hash")); 60 browser(), embedded_test_server()->GetURL("/title1.html#hash"));
62 NavigateToUntrackedUrl(); 61 NavigateToUntrackedUrl();
63 62
64 histogram_tester_.ExpectTotalCount(internal::kHistogramDomContentLoaded, 1); 63 histogram_tester_.ExpectTotalCount(internal::kHistogramDomContentLoaded, 1);
65 histogram_tester_.ExpectTotalCount(internal::kHistogramLoad, 1); 64 histogram_tester_.ExpectTotalCount(internal::kHistogramLoad, 1);
66 histogram_tester_.ExpectTotalCount(internal::kHistogramFirstLayout, 1); 65 histogram_tester_.ExpectTotalCount(internal::kHistogramFirstLayout, 1);
67 } 66 }
68 67
69 IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest, 68 IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest,
70 DISABLED_SameUrlNavigation) { 69 SameUrlNavigation) {
71 ASSERT_TRUE(embedded_test_server()->Start()); 70 ASSERT_TRUE(embedded_test_server()->Start());
72 71
73 ui_test_utils::NavigateToURL(browser(), 72 ui_test_utils::NavigateToURL(browser(),
74 embedded_test_server()->GetURL("/title1.html")); 73 embedded_test_server()->GetURL("/title1.html"));
75 ui_test_utils::NavigateToURL(browser(), 74 ui_test_utils::NavigateToURL(browser(),
76 embedded_test_server()->GetURL("/title1.html")); 75 embedded_test_server()->GetURL("/title1.html"));
77 NavigateToUntrackedUrl(); 76 NavigateToUntrackedUrl();
78 77
79 // We expect one histogram sample for each navigation to title1.html. 78 // We expect one histogram sample for each navigation to title1.html.
80 histogram_tester_.ExpectTotalCount(internal::kHistogramCommit, 2); 79 histogram_tester_.ExpectTotalCount(internal::kHistogramCommit, 2);
(...skipping 134 matching lines...) Expand 10 before | Expand all | Expand 10 after
215 ASSERT_TRUE(embedded_test_server()->Start()); 214 ASSERT_TRUE(embedded_test_server()->Start());
216 215
217 ui_test_utils::NavigateToURL( 216 ui_test_utils::NavigateToURL(
218 browser(), embedded_test_server()->GetURL( 217 browser(), embedded_test_server()->GetURL(
219 "/page_load_metrics/document_write_no_script.html")); 218 "/page_load_metrics/document_write_no_script.html"));
220 NavigateToUntrackedUrl(); 219 NavigateToUntrackedUrl();
221 220
222 histogram_tester_.ExpectTotalCount( 221 histogram_tester_.ExpectTotalCount(
223 internal::kHistogramDocWriteBlockParseStartToFirstContentfulPaint, 0); 222 internal::kHistogramDocWriteBlockParseStartToFirstContentfulPaint, 0);
224 } 223 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698