Fix flaky MetricsWebContentsObserverBrowserTests

Fix flaky MetricsWebContentsObserverBrowserTests

This reverts commit 58ac1adec45fcd08d91d2c09e0b2c17ed3d181cf, which
disabled a few flaky tests, and fixes those tests so they are no longer
flaky.

In a follow up change, we'll roll back
https://codereview.chromium.org/2172183002
since this change addresses the flakes caused by that patch.

BUG=630549
Committed: https://crrev.com/810c47d4645d63abbda6bbdc11b617115d755bd6
Cr-Commit-Position: refs/heads/master@{#407260}

[Bryan McQuade, 2016-07-22 19:27:37]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[Bryan McQuade, 2016-07-22 19:28:11]

bmcquade@chromium.org changed reviewers:
+ csharrison@chromium.org

[commit-bot: I haz the power, 2016-07-22 19:28:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bryan McQuade, 2016-07-22 19:28:20]

PTAL

[Charlie Harrison, 2016-07-22 20:12:18]

LGTM!

[Bryan McQuade, 2016-07-22 20:22:41]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 20:22:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 20:57:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 20:57:11]

Dry run: This issue passed the CQ dry run.

[Bryan McQuade, 2016-07-22 20:57:54]

The CQ bit was checked by bmcquade@chromium.org

[Bryan McQuade, 2016-07-22 20:57:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
csharrison@chromium.org
Link to the patchset: https://codereview.chromium.org/2176803002/#ps20001
(title: "switch to about:blank")

[commit-bot: I haz the power, 2016-07-22 20:58:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 21:03:44]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-22 21:05:46]

Description was changed from

==========
Fix flaky MetricsWebContentsObserverBrowserTests

This reverts commit 58ac1adec45fcd08d91d2c09e0b2c17ed3d181cf, which
disabled a few flaky tests, and fixes those tests so they are no longer
flaky.

In a follow up change, we'll roll back
https://codereview.chromium.org/2172183002
since this change addresses the flakes caused by that patch.

BUG=630549
==========

to

==========
Fix flaky MetricsWebContentsObserverBrowserTests

This reverts commit 58ac1adec45fcd08d91d2c09e0b2c17ed3d181cf, which
disabled a few flaky tests, and fixes those tests so they are no longer
flaky.

In a follow up change, we'll roll back
https://codereview.chromium.org/2172183002
since this change addresses the flakes caused by that patch.

BUG=630549

Committed: https://crrev.com/810c47d4645d63abbda6bbdc11b617115d755bd6
Cr-Commit-Position: refs/heads/master@{#407260}
==========

[commit-bot: I haz the power, 2016-07-22 21:05:46]

Patchset 2 (id:??) landed as
https://crrev.com/810c47d4645d63abbda6bbdc11b617115d755bd6
Cr-Commit-Position: refs/heads/master@{#407260}

[Charlie Harrison, 2016-07-22 21:10:28]

Do you know why the tests were failing without about:blank?

[Bryan McQuade, 2016-07-22 21:14:57]

Not sure. Seems specific to Windows, 4 for 4 failures. Perhaps we have
special handling of chrome URLs on Windows?

On Fri, Jul 22, 2016, 5:10 PM <csharrison@chromium.org> wrote:

> Do you know why the tests were failing without about:blank?
>
> https://codereview.chromium.org/2176803002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Charlie Harrison, 2016-07-22 21:16:04]

It's possible. I think a race condition might be more likely, as about:blank has
special semantics (it's synchronous, for one).