Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2186653002: [DevTools] Remove V8InspectorSession::backtraceObjectGroup. (Closed)

Created:
4 years, 4 months ago by dgozman
Modified:
4 years, 4 months ago
Reviewers:
kozy
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Remove V8InspectorSession::backtraceObjectGroup. BUG=631162 Committed: https://crrev.com/725300a775eaf6b8c24b4ab02e36dcb69575faca Cr-Commit-Position: refs/heads/master@{#407952}

Patch Set 1 #

Total comments: 2

Patch Set 2 : targetNodeId #

Messages

Total messages: 11 (4 generated)
dgozman
Take a look please.
4 years, 4 months ago (2016-07-26 17:09:14 UTC) #2
kozy
https://codereview.chromium.org/2186653002/diff/1/third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js File third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js (right): https://codereview.chromium.org/2186653002/diff/1/third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js#newcode154 third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js:154: var targetNode = auxData["targetNode"] ? domModel.nodeForId(auxData["targetNode"]) : null; targetNodeId?
4 years, 4 months ago (2016-07-26 17:27:56 UTC) #3
dgozman
https://codereview.chromium.org/2186653002/diff/1/third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js File third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js (right): https://codereview.chromium.org/2186653002/diff/1/third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js#newcode154 third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js:154: var targetNode = auxData["targetNode"] ? domModel.nodeForId(auxData["targetNode"]) : null; On ...
4 years, 4 months ago (2016-07-26 19:12:17 UTC) #4
kozy
lgtm % targetNode -> targetNodeId
4 years, 4 months ago (2016-07-26 19:12:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2186653002/20001
4 years, 4 months ago (2016-07-26 19:18:28 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-26 23:05:42 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 23:07:33 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/725300a775eaf6b8c24b4ab02e36dcb69575faca
Cr-Commit-Position: refs/heads/master@{#407952}

Powered by Google App Engine
This is Rietveld 408576698