third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp - Issue 2186653002: [DevTools] Remove V8InspectorSession::backtraceObjectGroup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp

Issue 2186653002: [DevTools] Remove V8InspectorSession::backtraceObjectGroup. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: targetNodeId Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h ('k') | third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp

index 7241c7d1a461c557a89f9d5d50c9a35d1f2458ca..8f0406ad5431ba90ee76538f63f6b8c48e7d4296 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp

@@ -519,8 +519,7 @@ void InspectorDOMDebuggerAgent::descriptionForDOMEvent(Node* target, int breakpo

if ((1 << breakpointType) & inheritableDOMBreakpointTypesMask) {

// For inheritable breakpoint types, target node isn't always the same as the node that owns a breakpoint.

// Target node may be unknown to frontend, so we need to push it first.

- std::unique_ptr<protocol::Runtime::API::RemoteObject> targetNodeObject = m_domAgent->resolveNode(target, V8InspectorSession::backtraceObjectGroup);

- description->setValue("targetNode", protocol::SerializedValue::create(targetNodeObject->toJSONString()));

+ description->setInteger("targetNodeId", m_domAgent->pushNodePathToFrontend(target));

// Find breakpoint owner node.

if (!insertion)