third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js - Issue 2186653002: [DevTools] Remove V8InspectorSession::backtraceObjectGroup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js

Issue 2186653002: [DevTools] Remove V8InspectorSession::backtraceObjectGroup. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: targetNodeId Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js ('k') | third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js b/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js

index 8f5788534c55d5ca3a39619770d70316599d89c0..b7934b678f66b806f81d66b6ea3f20e7d19317db 100644

--- a/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js

+++ b/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js

@@ -276,15 +276,6 @@ WebInspector.SourcesPanel.prototype = {

this.sidebarPanes.callstack.update(details);

/**

- * @param {!Element} element

- * @this {WebInspector.SourcesPanel}

- */

- function didCreateBreakpointHitStatusMessage(element)

- {

- this.sidebarPanes.callstack.setStatus(element);

- }

- /**

* @param {!WebInspector.LiveLocation} liveLocation

* @this {WebInspector.SourcesPanel}

@@ -302,7 +293,7 @@ WebInspector.SourcesPanel.prototype = {

if (details.reason === WebInspector.DebuggerModel.BreakReason.DOM) {

WebInspector.domBreakpointsSidebarPane.highlightBreakpoint(details.auxData);

- WebInspector.domBreakpointsSidebarPane.createBreakpointHitStatusMessage(details, didCreateBreakpointHitStatusMessage.bind(this));

+ this.sidebarPanes.callstack.setStatus(WebInspector.domBreakpointsSidebarPane.createBreakpointHitStatusMessage(details));

} else if (details.reason === WebInspector.DebuggerModel.BreakReason.EventListener) {

var eventName = details.auxData["eventName"];

var targetName = details.auxData["targetName"];