Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 218613013: DevTools: Decouple shortcuts from actions, introduce shortcut contexts (Closed)

Created:
6 years, 8 months ago by apavlov
Modified:
6 years, 8 months ago
Reviewers:
eustas, vsevik, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: Decouple shortcuts from actions, introduce shortcut contexts R=eustas, pfeldman, vsevik BUG=174309 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171867

Patch Set 1 : #

Patch Set 2 : Rebased patch #

Patch Set 3 : Fix context-related sort order #

Total comments: 13

Patch Set 4 : Address comments - take 1 #

Total comments: 14

Patch Set 5 : Address comments, handle Dialog key events in the glasspane keydown handler #

Total comments: 2

Patch Set 6 : Do not introduce SourceFrame flavor just yet #

Patch Set 7 : Fix test #

Patch Set 8 : Rebased patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+266 lines, -92 lines) Patch
M LayoutTests/inspector/map.html View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M Source/devtools/devtools.gypi View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
A Source/devtools/front_end/ActionRegistry.js View 1 2 3 1 chunk +63 lines, -0 lines 0 comments Download
M Source/devtools/front_end/AdvancedSearchView.js View 1 2 3 4 5 6 7 1 chunk +1 line, -4 lines 0 comments Download
M Source/devtools/front_end/Context.js View 1 2 3 6 chunks +23 lines, -6 lines 0 comments Download
M Source/devtools/front_end/Dialog.js View 1 2 3 4 2 chunks +15 lines, -0 lines 0 comments Download
M Source/devtools/front_end/Drawer.js View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/InspectorView.js View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M Source/devtools/front_end/KeyboardShortcut.js View 1 2 3 4 3 chunks +39 lines, -22 lines 0 comments Download
M Source/devtools/front_end/Main.js View 1 2 3 4 5 6 7 3 chunks +6 lines, -9 lines 0 comments Download
M Source/devtools/front_end/ModuleManager.js View 1 2 3 4 3 chunks +64 lines, -24 lines 0 comments Download
M Source/devtools/front_end/TabbedPane.js View 1 2 3 3 chunks +4 lines, -2 lines 0 comments Download
M Source/devtools/front_end/inspector.html View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/modules.js View 1 2 3 4 9 chunks +25 lines, -17 lines 0 comments Download
M Source/devtools/front_end/utilities.js View 1 2 3 3 chunks +14 lines, -1 line 0 comments Download
M Source/devtools/scripts/frontend_modules.json View 1 2 3 4 5 6 7 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 17 (0 generated)
apavlov
6 years, 8 months ago (2014-04-01 16:38:50 UTC) #1
pfeldman
https://codereview.chromium.org/218613013/diff/60001/Source/devtools/front_end/ActionRegistry.js File Source/devtools/front_end/ActionRegistry.js (right): https://codereview.chromium.org/218613013/diff/60001/Source/devtools/front_end/ActionRegistry.js#newcode14 Source/devtools/front_end/ActionRegistry.js:14: WebInspector.ActionRegistry.prototype = { This is a too small step ...
6 years, 8 months ago (2014-04-10 09:35:44 UTC) #2
apavlov
On 2014/04/10 09:35:44, pfeldman wrote: > https://codereview.chromium.org/218613013/diff/60001/Source/devtools/front_end/ActionRegistry.js > File Source/devtools/front_end/ActionRegistry.js (right): > > https://codereview.chromium.org/218613013/diff/60001/Source/devtools/front_end/ActionRegistry.js#newcode14 > ...
6 years, 8 months ago (2014-04-10 09:59:09 UTC) #3
pfeldman
https://codereview.chromium.org/218613013/diff/60001/Source/devtools/front_end/ActionRegistry.js File Source/devtools/front_end/ActionRegistry.js (right): https://codereview.chromium.org/218613013/diff/60001/Source/devtools/front_end/ActionRegistry.js#newcode17 Source/devtools/front_end/ActionRegistry.js:17: WebInspector.moduleManager.extensions(WebInspector.ActionDelegate).forEach(registerExtension, this); Do this from constructor instead? https://codereview.chromium.org/218613013/diff/60001/Source/devtools/front_end/ActionRegistry.js#newcode37 Source/devtools/front_end/ActionRegistry.js:37: ...
6 years, 8 months ago (2014-04-14 13:10:44 UTC) #4
apavlov
https://codereview.chromium.org/218613013/diff/60001/Source/devtools/front_end/ActionRegistry.js File Source/devtools/front_end/ActionRegistry.js (right): https://codereview.chromium.org/218613013/diff/60001/Source/devtools/front_end/ActionRegistry.js#newcode17 Source/devtools/front_end/ActionRegistry.js:17: WebInspector.moduleManager.extensions(WebInspector.ActionDelegate).forEach(registerExtension, this); On 2014/04/14 13:10:44, pfeldman wrote: > Do ...
6 years, 8 months ago (2014-04-15 13:33:13 UTC) #5
apavlov
PTAL. This is holding the reload/hard-reload key forwarding into the DevTools.
6 years, 8 months ago (2014-04-17 09:31:45 UTC) #6
pfeldman
https://codereview.chromium.org/218613013/diff/80001/Source/devtools/front_end/AdvancedSearchView.js File Source/devtools/front_end/AdvancedSearchView.js (right): https://codereview.chromium.org/218613013/diff/80001/Source/devtools/front_end/AdvancedSearchView.js#newcode370 Source/devtools/front_end/AdvancedSearchView.js:370: if (context.flavor(WebInspector.Dialog)) We should not make everything dialog-aware. https://codereview.chromium.org/218613013/diff/80001/Source/devtools/front_end/Dialog.js ...
6 years, 8 months ago (2014-04-17 10:40:25 UTC) #7
apavlov
https://codereview.chromium.org/218613013/diff/80001/Source/devtools/front_end/AdvancedSearchView.js File Source/devtools/front_end/AdvancedSearchView.js (right): https://codereview.chromium.org/218613013/diff/80001/Source/devtools/front_end/AdvancedSearchView.js#newcode370 Source/devtools/front_end/AdvancedSearchView.js:370: if (context.flavor(WebInspector.Dialog)) On 2014/04/17 10:40:25, pfeldman wrote: > We ...
6 years, 8 months ago (2014-04-17 12:42:22 UTC) #8
pfeldman
lgtm https://codereview.chromium.org/218613013/diff/100001/Source/devtools/front_end/SourceFrame.js File Source/devtools/front_end/SourceFrame.js (right): https://codereview.chromium.org/218613013/diff/100001/Source/devtools/front_end/SourceFrame.js#newcode433 Source/devtools/front_end/SourceFrame.js:433: WebInspector.context.setFlavor(WebInspector.SourceFrame, null); Lets do it later.
6 years, 8 months ago (2014-04-17 14:18:21 UTC) #9
apavlov
https://codereview.chromium.org/218613013/diff/100001/Source/devtools/front_end/SourceFrame.js File Source/devtools/front_end/SourceFrame.js (right): https://codereview.chromium.org/218613013/diff/100001/Source/devtools/front_end/SourceFrame.js#newcode433 Source/devtools/front_end/SourceFrame.js:433: WebInspector.context.setFlavor(WebInspector.SourceFrame, null); On 2014/04/17 14:18:21, pfeldman wrote: > Lets ...
6 years, 8 months ago (2014-04-17 14:23:19 UTC) #10
apavlov
The CQ bit was checked by apavlov@chromium.org
6 years, 8 months ago (2014-04-17 14:38:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/218613013/140001
6 years, 8 months ago (2014-04-17 14:38:54 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-17 14:39:05 UTC) #13
commit-bot: I haz the power
Failed to apply patch for Source/devtools/scripts/frontend_modules.json: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 8 months ago (2014-04-17 14:39:05 UTC) #14
apavlov
The CQ bit was checked by apavlov@chromium.org
6 years, 8 months ago (2014-04-17 14:50:33 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/218613013/160001
6 years, 8 months ago (2014-04-17 14:50:49 UTC) #16
commit-bot: I haz the power
6 years, 8 months ago (2014-04-17 17:16:35 UTC) #17
Message was sent while issue was closed. 
Change committed as 171867

Powered by Google App Engine
This is Rietveld 408576698