Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: Source/devtools/front_end/Drawer.js

Issue 218613013: DevTools: Decouple shortcuts from actions, introduce shortcut contexts (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebased patch Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/Dialog.js ('k') | Source/devtools/front_end/InspectorView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/Drawer.js
diff --git a/Source/devtools/front_end/Drawer.js b/Source/devtools/front_end/Drawer.js
index e13a25473cc26378b20776e0a53445d64713fb05..698763742e850bff671552d28d76a33ad8a4c8af 100644
--- a/Source/devtools/front_end/Drawer.js
+++ b/Source/devtools/front_end/Drawer.js
@@ -160,7 +160,7 @@ WebInspector.Drawer.prototype = {
},
/**
- * @return {!WebInspector.View} view
+ * @return {?WebInspector.View} view
*/
_visibleView: function()
{
@@ -173,7 +173,7 @@ WebInspector.Drawer.prototype = {
_tabSelected: function(event)
{
var tabId = this._tabbedPane.selectedTabId;
- if (event.data["isUserGesture"] && !this._tabbedPane.isTabCloseable(tabId))
+ if (tabId && event.data["isUserGesture"] && !this._tabbedPane.isTabCloseable(tabId))
this._lastSelectedViewSetting.set(tabId);
},
@@ -194,7 +194,7 @@ WebInspector.Drawer.prototype = {
},
/**
- * @return {string}
+ * @return {?string}
*/
selectedViewId: function()
{
« no previous file with comments | « Source/devtools/front_end/Dialog.js ('k') | Source/devtools/front_end/InspectorView.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698