Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1204)

Unified Diff: Source/devtools/front_end/TabbedPane.js

Issue 218613013: DevTools: Decouple shortcuts from actions, introduce shortcut contexts (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebased patch Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/ModuleManager.js ('k') | Source/devtools/front_end/inspector.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/TabbedPane.js
diff --git a/Source/devtools/front_end/TabbedPane.js b/Source/devtools/front_end/TabbedPane.js
index 6b2ebf2c4ac63bd6531169ff235d4e1497f18720..5c29a3db73f8130c89e359927f1fd9784e794036 100644
--- a/Source/devtools/front_end/TabbedPane.js
+++ b/Source/devtools/front_end/TabbedPane.js
@@ -58,7 +58,7 @@ WebInspector.TabbedPane.EventTypes = {
WebInspector.TabbedPane.prototype = {
/**
- * @return {!WebInspector.View}
+ * @return {?WebInspector.View}
*/
get visibleView()
{
@@ -82,7 +82,7 @@ WebInspector.TabbedPane.prototype = {
},
/**
- * @return {string}
+ * @return {?string}
*/
get selectedTabId()
{
@@ -1144,6 +1144,8 @@ WebInspector.ExtensibleTabbedPaneController.prototype = {
_tabSelected: function(event)
{
var tabId = this._tabbedPane.selectedTabId;
+ if (!tabId)
+ return;
var view = this._viewForId(tabId);
if (view)
this._tabbedPane.changeTabView(tabId, view);
« no previous file with comments | « Source/devtools/front_end/ModuleManager.js ('k') | Source/devtools/front_end/inspector.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698