cc/output/swap_promise.h - Issue 2185823005: Make RenderViewImpl::OnForceRedraw more robust

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/output/swap_promise.h

Issue 2185823005: Make RenderViewImpl::OnForceRedraw more robust (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Reimplemented using ForcedRedrawSwapPromise Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/output/swap_promise.h

diff --git a/cc/output/swap_promise.h b/cc/output/swap_promise.h

index f3c3fbdde811651bb9a941d307b7372c3103ddee..5298aee7cc8ef830867055173878089374a59629 100644

--- a/cc/output/swap_promise.h

+++ b/cc/output/swap_promise.h

@@ -55,7 +55,9 @@ class CC_EXPORT SwapPromise {

virtual void DidActivate() = 0;

virtual void DidSwap(CompositorFrameMetadata* metadata) = 0;

- virtual void DidNotSwap(DidNotSwapReason reason) = 0;

+ // Returns true if this promise should remain active (should not be broken by

+ // the owner).

+ virtual bool DidNotSwap(DidNotSwapReason reason) = 0;

// This is called when the main thread starts a (blocking) commit

virtual void OnCommit() {}