cc/output/latency_info_swap_promise.cc - Issue 2185823005: Make RenderViewImpl::OnForceRedraw more robust

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/output/latency_info_swap_promise.cc

Issue 2185823005: Make RenderViewImpl::OnForceRedraw more robust (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Reimplemented using ForcedRedrawSwapPromise Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/output/latency_info_swap_promise.cc

diff --git a/cc/output/latency_info_swap_promise.cc b/cc/output/latency_info_swap_promise.cc

index f20eb2d469b511f822137c7551b48ea471621bbc..02360b992e555691ea2f32e93dfca4409761b7dd 100644

--- a/cc/output/latency_info_swap_promise.cc

+++ b/cc/output/latency_info_swap_promise.cc

@@ -40,12 +40,13 @@ void LatencyInfoSwapPromise::DidSwap(CompositorFrameMetadata* metadata) {

metadata->latency_info.push_back(latency_);

}

-void LatencyInfoSwapPromise::DidNotSwap(DidNotSwapReason reason) {

+bool LatencyInfoSwapPromise::DidNotSwap(DidNotSwapReason reason) {

latency_.AddLatencyNumber(DidNotSwapReasonToLatencyComponentType(reason), 0,

0);

// TODO(miletus): Turn this back on once per-event LatencyInfo tracking

// is enabled in GPU side.

// DCHECK(latency_.terminated);

+ return false;

}

int64_t LatencyInfoSwapPromise::TraceId() const {