cc/trees/layer_tree_impl.h - Issue 2185823005: Make RenderViewImpl::OnForceRedraw more robust

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/trees/layer_tree_impl.h

Issue 2185823005: Make RenderViewImpl::OnForceRedraw more robust (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Reimplemented using ForcedRedrawSwapPromise Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/trees/layer_tree_impl.h

diff --git a/cc/trees/layer_tree_impl.h b/cc/trees/layer_tree_impl.h

index 3d032fcc50bf7998f0b1382491b6891ad30072a0..e4f3d492b868886f8962fccabb4774fd1f2cd4cc 100644

--- a/cc/trees/layer_tree_impl.h

+++ b/cc/trees/layer_tree_impl.h

@@ -358,9 +358,9 @@ class CC_EXPORT LayerTreeImpl {

// on the active tree if a new tree is activated.

void QueuePinnedSwapPromise(std::unique_ptr<SwapPromise> swap_promise);

- // Take the |new_swap_promise| and append it to |swap_promise_list_|.

+ // Takes the |new_swap_promises| and appends it to |swap_promise_list_|.

void PassSwapPromises(

- std::vector<std::unique_ptr<SwapPromise>>* new_swap_promise);

+ std::vector<std::unique_ptr<SwapPromise>>* new_swap_promises);

void FinishSwapPromises(CompositorFrameMetadata* metadata);

void BreakSwapPromises(SwapPromise::DidNotSwapReason reason);