third_party/WebKit/Source/platform/inspector_protocol/DispatcherBase.cpp - Issue 2185233002: [DevTools] Added Runtime.awaitPromise protocol method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/inspector_protocol/DispatcherBase.cpp

Issue 2185233002: [DevTools] Added Runtime.awaitPromise protocol method (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: alligned output Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-await-promise-expected.txt ('k') | third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/inspector_protocol/DispatcherBase.cpp

diff --git a/third_party/WebKit/Source/platform/inspector_protocol/DispatcherBase.cpp b/third_party/WebKit/Source/platform/inspector_protocol/DispatcherBase.cpp

index 49422eba09a9ca12f0c037896ab173c95bd86a1d..8f154f42ac286f04d1d712d44aa3c8d527c659e9 100644

--- a/third_party/WebKit/Source/platform/inspector_protocol/DispatcherBase.cpp

+++ b/third_party/WebKit/Source/platform/inspector_protocol/DispatcherBase.cpp

@@ -34,7 +34,7 @@ void DispatcherBase::Callback::dispose()

void DispatcherBase::Callback::sendIfActive(std::unique_ptr<protocol::DictionaryValue> partialMessage, const ErrorString& invocationError)

{

- if (!m_backendImpl->get())

+ if (!m_backendImpl || !m_backendImpl->get())

return;

m_backendImpl->get()->sendResponse(m_callId, invocationError, nullptr, std::move(partialMessage));

m_backendImpl = nullptr;