chrome/test/data/webui/settings/languages_page_browsertest.js - Issue 2184893002: Settings Router Refactor: Remove route.page legacy property.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/webui/settings/languages_page_browsertest.js

Issue 2184893002: Settings Router Refactor: Remove route.page legacy property. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@0217-settings-refactor-settings-menu

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/settings_page/main_page_behavior.js ('K') | « chrome/browser/resources/settings/settings_page/settings_router.js ('k') | chrome/test/data/webui/settings/route_tests.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/webui/settings/languages_page_browsertest.js

diff --git a/chrome/test/data/webui/settings/languages_page_browsertest.js b/chrome/test/data/webui/settings/languages_page_browsertest.js

index 6568a0658b5153d273b20c32889330bd437a1677..3c9bd09eab2eb395565699acd0a9b5c2f4772e21 100644

--- a/chrome/test/data/webui/settings/languages_page_browsertest.js

+++ b/chrome/test/data/webui/settings/languages_page_browsertest.js

@@ -68,16 +68,8 @@ TEST_F('SettingsLanguagesPageBrowserTest', 'MAYBE_LanguagesPage', function() {

teardown(function(done) {

// Close the section if we're in a sub-page.

- if (advanced.currentRoute.subpage.length == 0) {

- done();

- } else {

- advanced.currentRoute = {

- page: 'advanced',

- section: '',

- subpage: [],

- };

- setTimeout(done);

- }

+ settings.navigateTo(settings.Route.ADVANCED);

+ setTimeout(done);

});

test('manage languages', function() {