Settings Router Refactor: Remove route.page legacy property.

chrome/browser/resources/settings/settings_page/main_page_behavior.js

Index: chrome/browser/resources/settings/settings_page/main_page_behavior.js
diff --git a/chrome/browser/resources/settings/settings_page/main_page_behavior.js b/chrome/browser/resources/settings/settings_page/main_page_behavior.js
index 933a0ec4baab3a6cd5c57404141fed70b549de6c..553e82632751a2f734b9016397ddc72bba6d16ce 100644
--- a/chrome/browser/resources/settings/settings_page/main_page_behavior.js
+++ b/chrome/browser/resources/settings/settings_page/main_page_behavior.js
@@ -407,10 +407,8 @@ var RoutableBehaviorImpl = {
           this.collapseSection(section);
       }
 
-      if (newRoute && newRoute.section &&
-          this.$$('[data-page=' + newRoute.page + ']')) {
+      if (newRoute && newRoute.section && this.getSection_(newRoute.section))

[michaelpg, 2016/07/28 23:22:32]

is this just asking if the section is visible? can we just check .hidden or
offsetHeight or something?

[tommycli, 2016/07/29 00:03:35]

I added a comment. This actually scrolls to the desired section if this main
page contains the route's section.

For instance, BASIC page should ignore it if we're navigating to the PRIVACY
section, since the ADVANCED main page will handle the scrolling.

[michaelpg, 2016/07/29 00:21:12]

oh, that makes sense. Ugh, this element was never meant to be repeated in the
DOM. Some of this stuff should probably move at some point.

         this.scrollToSection_();
-      }
     }
   },