chrome/browser/resources/settings/settings_page/settings_router.js - Issue 2184893002: Settings Router Refactor: Remove route.page legacy property.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_page/settings_router.js

Issue 2184893002: Settings Router Refactor: Remove route.page legacy property. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@0217-settings-refactor-settings-menu

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/settings_page/main_page_behavior.js ('K') | « chrome/browser/resources/settings/settings_page/main_page_behavior.js ('k') | chrome/test/data/webui/settings/languages_page_browsertest.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/settings_page/settings_router.js

diff --git a/chrome/browser/resources/settings/settings_page/settings_router.js b/chrome/browser/resources/settings/settings_page/settings_router.js

index 91b7db3ef0702cd17fdf0b8af141abc0ab4df71c..5cd1f6d9dd8248296c7969954ec6b8fa69aaa4c7 100644

--- a/chrome/browser/resources/settings/settings_page/settings_router.js

+++ b/chrome/browser/resources/settings/settings_page/settings_router.js

@@ -22,8 +22,6 @@ Polymer({

* The current active route. This may only be updated via the global

* function settings.navigateTo.

- * currentRoute.page refers to top-level pages such as Basic and Advanced.

- *

* currentRoute.section is only non-empty when the user is on a subpage. If

* the user is on Basic, for instance, this is an empty string.