Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 2184823002: [arm] Clean up the use of UNALIGNED_ACCESSES. (Closed)

Created:
4 years, 4 months ago by jbramley
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, oth, rmcilroy, v8-ppc-ports_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[arm] Clean up the use of UNALIGNED_ACCESSES. All supported ARM targets support unaligned accesses for integer accesses. This patch removes the remnants of support for older targets. BUG=v8:5077 Committed: https://crrev.com/cc00ba2df2af2b37f15045ff8d37d25838041df5 Cr-Commit-Position: refs/heads/master@{#38099}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -126 lines) Patch
M src/arm/assembler-arm.cc View 4 chunks +1 line, -7 lines 0 comments Download
M src/arm/codegen-arm.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +1 line, -11 lines 0 comments Download
M src/arm/simulator-arm.cc View 2 chunks +33 lines, -87 lines 0 comments Download
M src/flag-definitions.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/globals.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/interpreter/interpreter-assembler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/regexp/arm/regexp-macro-assembler-arm.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/regexp/arm/regexp-macro-assembler-arm.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/regexp/arm64/regexp-macro-assembler-arm64.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/regexp/arm64/regexp-macro-assembler-arm64.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/regexp/regexp-macro-assembler.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-assembler-arm.cc View 1 chunk +114 lines, -0 lines 0 comments Download

Messages

Total messages: 27 (12 generated)
jbramley
UNALIGNED_ACCESSES is still referred to by the PPC and S390 back ends, so I haven't ...
4 years, 4 months ago (2016-07-26 17:19:08 UTC) #2
epertoso
lgtm
4 years, 4 months ago (2016-07-27 12:05:32 UTC) #4
epertoso
lgtm
4 years, 4 months ago (2016-07-27 12:05:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2184823002/1
4 years, 4 months ago (2016-07-27 12:06:08 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/20340)
4 years, 4 months ago (2016-07-27 12:08:58 UTC) #9
jbramley
On 2016/07/27 12:08:58, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 4 months ago (2016-07-27 12:24:09 UTC) #10
epertoso
On 2016/07/27 12:24:09, jbramley wrote: > On 2016/07/27 12:08:58, commit-bot: I haz the power wrote: ...
4 years, 4 months ago (2016-07-27 12:41:13 UTC) #13
Yang
On 2016/07/27 12:41:13, epertoso wrote: > On 2016/07/27 12:24:09, jbramley wrote: > > On 2016/07/27 ...
4 years, 4 months ago (2016-07-27 13:01:30 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2184823002/1
4 years, 4 months ago (2016-07-27 13:06:13 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/20350)
4 years, 4 months ago (2016-07-27 13:09:05 UTC) #18
rmcilroy
Interpreter lgtm
4 years, 4 months ago (2016-07-27 13:15:00 UTC) #20
jbramley
On 2016/07/27 13:15:00, rmcilroy wrote: > Interpreter lgtm Thanks!
4 years, 4 months ago (2016-07-27 13:21:52 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2184823002/1
4 years, 4 months ago (2016-07-27 13:22:04 UTC) #23
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-27 13:24:33 UTC) #25
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 13:28:11 UTC) #27
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cc00ba2df2af2b37f15045ff8d37d25838041df5
Cr-Commit-Position: refs/heads/master@{#38099}

Powered by Google App Engine
This is Rietveld 408576698