Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2184753002: Add Sk4h_load4 for loading F16. (Closed)

Created:
4 years, 4 months ago by mtklein_C
Modified:
4 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add Sk4h_load4 for loading F16. Should feel very similar to Sk4h_store4: NEON uses its native instruction, SSE unpacks manually. Since we'll have our F16s in 4 Sk4h by the time we're done here, this also extracts an Sk4h->Sk4f routine from the old uint64_t->Sk4f one. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2184753002 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Committed: https://skia.googlesource.com/skia/+/f660b7cfcfbf3062f88e61f8320ea7051da72213

Patch Set 1 #

Patch Set 2 : typo #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -17 lines) Patch
M src/core/SkHalf.h View 2 chunks +11 lines, -8 lines 0 comments Download
M src/core/SkNx.h View 1 1 chunk +13 lines, -0 lines 0 comments Download
M src/core/SkRasterPipelineBlitter.cpp View 1 chunk +7 lines, -9 lines 0 comments Download
M src/opts/SkNx_neon.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/opts/SkNx_sse.h View 1 chunk +13 lines, -0 lines 1 comment Download

Messages

Total messages: 18 (13 generated)
mtklein_C
4 years, 4 months ago (2016-07-26 14:11:10 UTC) #9
msarett
lgtm https://codereview.chromium.org/2184753002/diff/20001/src/opts/SkNx_sse.h File src/opts/SkNx_sse.h (right): https://codereview.chromium.org/2184753002/diff/20001/src/opts/SkNx_sse.h#newcode406 src/opts/SkNx_sse.h:406: static inline void Sk4h_load4(const void* ptr, Sk4h* r, ...
4 years, 4 months ago (2016-07-26 14:25:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2184753002/20001
4 years, 4 months ago (2016-07-26 15:00:06 UTC) #14
mtklein
+Brians, is planar half float a format that's realistic to expect GPUs support?
4 years, 4 months ago (2016-07-26 15:00:49 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 15:01:23 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/f660b7cfcfbf3062f88e61f8320ea7051da72213

Powered by Google App Engine
This is Rietveld 408576698