Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2184413002: Merge ProgramDesc's for GL and Vulkan (Closed)

Created:
4 years, 4 months ago by egdaniel
Modified:
4 years, 4 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@minorPerf
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -525 lines) Patch
M gyp/gpu.gypi View 3 chunks +2 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLGpuProgramCache.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLProgram.h View 1 chunk +1 line, -1 line 0 comments Download
D src/gpu/gl/GrGLProgramDesc.h View 1 chunk +0 lines, -64 lines 0 comments Download
D src/gpu/gl/GrGLProgramDesc.cpp View 1 chunk +0 lines, -190 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
A src/gpu/glsl/GrGLSLProgramDesc.h View 1 chunk +63 lines, -0 lines 0 comments Download
A + src/gpu/glsl/GrGLSLProgramDesc.cpp View 1 3 chunks +8 lines, -11 lines 0 comments Download
M src/gpu/vk/GrVkPipeline.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/vk/GrVkPipelineState.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/vk/GrVkPipelineStateBuilder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/vk/GrVkPipelineStateBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/vk/GrVkPipelineStateCache.cpp View 2 1 chunk +4 lines, -4 lines 0 comments Download
D src/gpu/vk/GrVkProgramDesc.h View 1 chunk +0 lines, -68 lines 0 comments Download
D src/gpu/vk/GrVkProgramDesc.cpp View 1 chunk +0 lines, -168 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
egdaniel
4 years, 4 months ago (2016-07-28 16:10:46 UTC) #3
bsalomon
lgtm
4 years, 4 months ago (2016-07-28 16:19:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2184413002/20001
4 years, 4 months ago (2016-07-28 16:39:51 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86_64-Release-Vulkan-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Release-Vulkan-Trybot/builds/241)
4 years, 4 months ago (2016-07-28 16:49:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2184413002/40001
4 years, 4 months ago (2016-07-29 13:56:29 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 14:36:57 UTC) #13
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/0d9990f052670a8af29e1e775c414810f8fc6e86

Powered by Google App Engine
This is Rietveld 408576698