Issue 2184273002: Remove unused sk_app::WindowContext::presentRenderSurface

Issue 2184273002: Remove unused sk_app::WindowContext::presentRenderSurface (Closed)

Created:
4 years, 4 months ago by bsalomon

Modified:
4 years, 4 months ago

Reviewers:
jvanverth1

CC:
reviews_skia.org

Base URL:
https://chromium.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -33 lines)			Patch
M	tools/viewer/sk_app/GLWindowContext.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tools/viewer/sk_app/VulkanWindowContext.cpp	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	tools/viewer/sk_app/WindowContext.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	tools/viewer/sk_app/WindowContext.cpp	View	1 chunk	+0 lines, -27 lines	0 comments	Download

Dependent Patchsets:

Total messages: 9 (5 generated)

jvanverth1

lgtm You'll probably want to remove the creation of the offscreen surface in WindowContext::createSurface() as ...

4 years, 4 months ago (2016-07-28 12:47:24 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2184273002/1

4 years, 4 months ago (2016-07-28 13:33:45 UTC) #7

commit-bot: I haz the power

4 years, 4 months ago (2016-07-28 15:53:15 UTC) #9

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1c58696112a5d7bf1acbcc337099b0bf5eb80650