Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 2191673002: Remove unused render target members from GL and VK sk_app::WindowContext classes (Closed)

Created:
4 years, 4 months ago by bsalomon
Modified:
4 years, 4 months ago
Reviewers:
jvanverth1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@noapply
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove unused render target members from GL and VK sk_app::WindowContext classes GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2191673002 Committed: https://skia.googlesource.com/skia/+/4484d6ac788d90fe937068bf429032914f17ba60

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M tools/viewer/sk_app/GLWindowContext.h View 2 chunks +0 lines, -2 lines 0 comments Download
M tools/viewer/sk_app/GLWindowContext.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M tools/viewer/sk_app/VulkanWindowContext.h View 1 chunk +0 lines, -1 line 0 comments Download
M tools/viewer/sk_app/VulkanWindowContext.cpp View 2 chunks +0 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (6 generated)
bsalomon
4 years, 4 months ago (2016-07-27 21:26:41 UTC) #3
jvanverth1
lgtm
4 years, 4 months ago (2016-07-28 12:50:53 UTC) #4
commit-bot: I haz the power
This CL has an open dependency (Issue 2184273002 Patch 1). Please resolve the dependency and ...
4 years, 4 months ago (2016-07-28 13:33:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2191673002/1
4 years, 4 months ago (2016-07-28 18:03:04 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 18:49:15 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/4484d6ac788d90fe937068bf429032914f17ba60

Powered by Google App Engine
This is Rietveld 408576698