Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2184113002: [bindings] Use new SetAlignedPointerInInternalFields V8 API (Closed)

Created:
4 years, 4 months ago by Camillo Bruni
Modified:
4 years, 4 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[bindings] Use new SetAlignedPointerInInternalFields V8 API This should help to reduce the overhead of setting up DOM wrappers. BUG=chromium:630217, chromium:595492 Committed: https://crrev.com/31cc1d1f5b9f4bdcbc69cbc788ffc31696895a60 Cr-Commit-Position: refs/heads/master@{#410191}

Patch Set 1 #

Total comments: 1

Patch Set 2 : addressing comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.h View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Camillo Bruni
PTAL this will land in couple of days using the new API https://codereview.chromium.org/2185963002
4 years, 4 months ago (2016-08-03 15:40:54 UTC) #3
haraken
LGTM https://codereview.chromium.org/2184113002/diff/1/third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.h File third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.h (right): https://codereview.chromium.org/2184113002/diff/1/third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.h#newcode75 third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.h:75: wrapper->SetAlignedPointerInInternalFields(2, indices, values); 2 => WTF_ARRAY_LENGTH
4 years, 4 months ago (2016-08-03 22:59:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2184113002/20001
4 years, 4 months ago (2016-08-05 20:36:25 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-05 22:26:11 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 22:29:32 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/31cc1d1f5b9f4bdcbc69cbc788ffc31696895a60
Cr-Commit-Position: refs/heads/master@{#410191}

Powered by Google App Engine
This is Rietveld 408576698