Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.h

Issue 2184113002: [bindings] Use new SetAlignedPointerInInternalFields V8 API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressing comment Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.h b/third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.h
index 66e4316ae67de0986cab4e2dd3cb133f9540d0ef..dd803b189220264797ff9663edf9e501e67e8b11 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.h
+++ b/third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.h
@@ -70,8 +70,9 @@ inline void V8DOMWrapper::setNativeInfo(v8::Isolate* isolate, v8::Local<v8::Obje
ASSERT(wrapper->InternalFieldCount() >= 2);
ASSERT(scriptWrappable);
ASSERT(wrapperTypeInfo);
- wrapper->SetAlignedPointerInInternalField(v8DOMWrapperObjectIndex, scriptWrappable);
- wrapper->SetAlignedPointerInInternalField(v8DOMWrapperTypeIndex, const_cast<WrapperTypeInfo*>(wrapperTypeInfo));
+ int indices[] = { v8DOMWrapperObjectIndex, v8DOMWrapperTypeIndex };
+ void* values[] = { scriptWrappable, const_cast<WrapperTypeInfo*>(wrapperTypeInfo) };
+ wrapper->SetAlignedPointerInInternalFields(WTF_ARRAY_LENGTH(indices), indices, values);
if (RuntimeEnabledFeatures::traceWrappablesEnabled()) {
auto perIsolateData = V8PerIsolateData::from(isolate);
// We notify ScriptWrappableVisitor about the new wrapper association,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698