[api] Add v8::Object::SetAlignedPointerInInternalFields

[api] Add v8::Object::SetAlignedPointerInInternalFields

This new API function allows for setting several internal fields at once.
By avoiding crossing the API each time for setting an internal property we
can speed up the wrapper creation which has to set two fields for every new
object.

BUG=chromium:630217
Committed: https://crrev.com/ce49c329735530d66bb98cb13b4a8f5b1f48500f
Cr-Commit-Position: refs/heads/master@{#38299}

[Camillo Bruni, 2016-07-27 11:23:57]

cbruni@chromium.org changed reviewers:
+ jochen@chromium.org

[Camillo Bruni, 2016-07-27 11:23:58]

PTAL

[jochen (gone - plz use gerrit), 2016-07-27 11:37:56]

https://codereview.chromium.org/2185963002/diff/40001/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/2185963002/diff/40001/include/v8.h#newcode2896
include/v8.h:2896: void* values[]);
can we inline the body in the header?

[Camillo Bruni, 2016-07-27 12:07:04]

On 2016/07/27 at 11:37:56, jochen wrote:
> https://codereview.chromium.org/2185963002/diff/40001/include/v8.h
> File include/v8.h (right):
> 
> https://codereview.chromium.org/2185963002/diff/40001/include/v8.h#newcode2896
> include/v8.h:2896: void* values[]);
> can we inline the body in the header?

Unless we make more things available in the v8.h header this is going to be
tricky (lot's of incomplete types).

[jochen (gone - plz use gerrit), 2016-07-27 12:19:48]

On 2016/07/27 at 12:07:04, cbruni wrote:
> On 2016/07/27 at 11:37:56, jochen wrote:
> > https://codereview.chromium.org/2185963002/diff/40001/include/v8.h
> > File include/v8.h (right):
> > 
> >
https://codereview.chromium.org/2185963002/diff/40001/include/v8.h#newcode2896
> > include/v8.h:2896: void* values[]);
> > can we inline the body in the header?
> 
> Unless we make more things available in the v8.h header this is going to be
tricky (lot's of incomplete types).

like this: https://cs.chromium.org/chromium/src/v8/include/v8.h?rcl=0&l=8224

[Camillo Bruni, 2016-07-27 13:20:37]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 13:20:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 13:44:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 13:44:30]

Dry run: This issue passed the CQ dry run.

[Camillo Bruni, 2016-07-27 15:31:47]

PTAL again
I can see a positive impact if I squint my eyes real hard.

[jochen (gone - plz use gerrit), 2016-07-29 09:47:45]

lgtm

[Michael Starzinger, 2016-07-29 09:50:52]

mstarzinger@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Michael Starzinger, 2016-07-29 09:50:53]

https://codereview.chromium.org/2185963002/diff/80001/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/2185963002/diff/80001/include/v8.h#newcode8263
include/v8.h:8263: I::WriteField(object, offset, value);
Isn't this missing a return? Otherwise the slow case will always be run.

https://codereview.chromium.org/2185963002/diff/80001/include/v8.h#newcode8284
include/v8.h:8284: I::WriteField(object, offset, value);
Isn't this missing a return? Otherwise the slow case will always be run.

[Camillo Bruni, 2016-08-03 13:30:26]

The CQ bit was checked by cbruni@chromium.org

[Camillo Bruni, 2016-08-03 13:30:26]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/2185963002/#ps120001
(title: "removing inlined helper")

[commit-bot: I haz the power, 2016-08-03 13:30:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 13:30:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 13:30:48]

CQ cannot get SignCLA result. Please try later.

[Camillo Bruni, 2016-08-03 13:51:51]

The CQ bit was checked by cbruni@chromium.org

[commit-bot: I haz the power, 2016-08-03 13:51:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 14:38:44]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-08-03 14:39:46]

Description was changed from

==========
[api] Add v8::Object::SetAlignedPointerInInternalFields

This new API function allows for setting several internal fields at once.
By avoiding crossing the API each time for setting an internal property we
can speed up the wrapper creation which has to set two fields for every new
object.

BUG=chromium:630217
==========

to

==========
[api] Add v8::Object::SetAlignedPointerInInternalFields

This new API function allows for setting several internal fields at once.
By avoiding crossing the API each time for setting an internal property we
can speed up the wrapper creation which has to set two fields for every new
object.

BUG=chromium:630217

Committed: https://crrev.com/ce49c329735530d66bb98cb13b4a8f5b1f48500f
Cr-Commit-Position: refs/heads/master@{#38299}
==========

[commit-bot: I haz the power, 2016-08-03 14:39:47]

Patchset 7 (id:??) landed as
https://crrev.com/ce49c329735530d66bb98cb13b4a8f5b1f48500f
Cr-Commit-Position: refs/heads/master@{#38299}