Refactor browser process coordinate transformation methods

content/browser/renderer_host/render_widget_host_view_base.cc

Index: content/browser/renderer_host/render_widget_host_view_base.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_base.cc b/content/browser/renderer_host/render_widget_host_view_base.cc
index 8b8907e262a95b8790a6b404c8ed0ccef5bc2a1e..07a6925959f301daeabc5610d5c47cc94d6879b2 100644
--- a/content/browser/renderer_host/render_widget_host_view_base.cc
+++ b/content/browser/renderer_host/render_widget_host_view_base.cc
@@ -400,11 +400,16 @@ gfx::PointF RenderWidgetHostViewBase::TransformPointToRootCoordSpaceF(
       gfx::ToRoundedPoint(point)));
 }
 
-void RenderWidgetHostViewBase::TransformPointToLocalCoordSpace(
+gfx::Point RenderWidgetHostViewBase::TransformPointToLocalCoordSpace(
     const gfx::Point& point,
-    const cc::SurfaceId& original_surface,
-    gfx::Point* transformed_point) {
-  *transformed_point = point;
+    const cc::SurfaceId& original_surface) {
+  return point;
+}
+
+gfx::Point RenderWidgetHostViewBase::TransformPointToCoordSpaceForView(
+    const gfx::Point& point,
+    RenderWidgetHostViewBase* target_view) {

[nasko, 2016/07/27 22:52:13]

target_view here should be |this|, right? Maybe add a DCHECK to ensure we don't
call it incorrectly.

[kenrb, 2016/07/28 16:24:38]

Not generally, this is really just a stub implementation to cover Android which
doesn't have any of the support for this yet. I have added a NOTREACHED() to
make this clearer.

+  return point;
 }
 
 void RenderWidgetHostViewBase::TextInputStateChanged(