Refactor browser process coordinate transformation methods

content/browser/renderer_host/render_widget_host_view_aura.cc

Index: content/browser/renderer_host/render_widget_host_view_aura.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_aura.cc b/content/browser/renderer_host/render_widget_host_view_aura.cc
index 284533c8122b0257a8b835f96de284d305bb3a0b..dea7854b62cc05d57dd728e5348945f48eaeddc4 100644
--- a/content/browser/renderer_host/render_widget_host_view_aura.cc
+++ b/content/browser/renderer_host/render_widget_host_view_aura.cc
@@ -2040,18 +2040,24 @@ void RenderWidgetHostViewAura::ProcessGestureEvent(
   host_->ForwardGestureEventWithLatencyInfo(event, latency);
 }
 
-void RenderWidgetHostViewAura::TransformPointToLocalCoordSpace(
+gfx::Point RenderWidgetHostViewAura::TransformPointToLocalCoordSpace(
     const gfx::Point& point,
-    const cc::SurfaceId& original_surface,
-    gfx::Point* transformed_point) {
+    const cc::SurfaceId& original_surface) {
+  gfx::Point transformed_point;
   // Transformations use physical pixels rather than DIP, so conversion
   // is necessary.
   gfx::Point point_in_pixels =
       gfx::ConvertPointToPixel(device_scale_factor_, point);
-  delegated_frame_host_->TransformPointToLocalCoordSpace(
-      point_in_pixels, original_surface, transformed_point);
-  *transformed_point =
-      gfx::ConvertPointToDIP(device_scale_factor_, *transformed_point);
+  transformed_point = delegated_frame_host_->TransformPointToLocalCoordSpace(
+      point_in_pixels, original_surface);
+  return gfx::ConvertPointToDIP(device_scale_factor_, transformed_point);
+}
+
+gfx::Point RenderWidgetHostViewAura::TransformPointToCoordSpaceForView(
+    const gfx::Point& point,
+    RenderWidgetHostViewBase* target_view) {
+  return delegated_frame_host_->TransformPointToCoordSpaceForView(point,
+                                                                  target_view);

[nasko, 2016/07/27 22:52:13]

Do we need a call to gfx::ConvertPointToDIP here like in the LocalCoordSpace
case?

[kenrb, 2016/07/28 16:24:38]

No, because that ends up happening later on when the point is passed to the
target_view, but that's a good point and it deserves a comment, which I have
added.

 }
 
 void RenderWidgetHostViewAura::FocusedNodeChanged(bool editable) {