Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2183963003:
[Mac/GN] Only specify a rpath for //chrome:chrome_helper_app in the component build. (Closed)
|
Created:
4 years, 4 months ago by Robert Sesek Modified:
4 years, 4 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Mac/GN] Only specify a rpath for //chrome:chrome_helper_app in the component build.
BUG=631833
R=dpranke@chromium.org, erikchen@chromium.org
Originally Committed: https://crrev.com/1905fc8c9e06650f75433a78e87e26477873da54
Reverted: https://crrev.com/95f93fb96fd66efe1a1ac330265124f84069ab78
Committed: https://chromium.googlesource.com/chromium/src/+/4860c3320f6268f980e68cb73167f90acf10a8e7
Patch Set 1 #Patch Set 2 : Fix, reland #Messages
Total messages: 21 (11 generated)
The CQ bit was checked by rsesek@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
rsesek@chromium.org changed reviewers: + dpranke@google.com
+dpranke for build OWNERS
dpranke@chromium.org changed reviewers: + dpranke@chromium.org
lgtm
The CQ bit was unchecked by rsesek@chromium.org
The CQ bit was checked by rsesek@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [Mac/GN] Only specify a rpath for //chrome:chrome_helper_app in the component build. BUG=631833 R=erikchen@chromium.org ========== to ========== [Mac/GN] Only specify a rpath for //chrome:chrome_helper_app in the component build. BUG=631833 R=erikchen@chromium.org Committed: https://crrev.com/1905fc8c9e06650f75433a78e87e26477873da54 Cr-Commit-Position: refs/heads/master@{#407988} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/1905fc8c9e06650f75433a78e87e26477873da54 Cr-Commit-Position: refs/heads/master@{#407988}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2187753002/ by tsergeant@chromium.org. The reason for reverting is: This is causing failures on Mac Build. See: https://build.chromium.org/p/chromium/builders/Mac/builds/18011.
Message was sent while issue was closed.
Description was changed from ========== [Mac/GN] Only specify a rpath for //chrome:chrome_helper_app in the component build. BUG=631833 R=erikchen@chromium.org Committed: https://crrev.com/1905fc8c9e06650f75433a78e87e26477873da54 Cr-Commit-Position: refs/heads/master@{#407988} ========== to ========== [Mac/GN] Only specify a rpath for //chrome:chrome_helper_app in the component build. BUG=631833 R=erikchen@chromium.org Originally Committed: https://crrev.com/1905fc8c9e06650f75433a78e87e26477873da54 Reverted: https://crrev.com/95f93fb96fd66efe1a1ac330265124f84069ab78 ==========
Message was sent while issue was closed.
Description was changed from ========== [Mac/GN] Only specify a rpath for //chrome:chrome_helper_app in the component build. BUG=631833 R=erikchen@chromium.org Originally Committed: https://crrev.com/1905fc8c9e06650f75433a78e87e26477873da54 Reverted: https://crrev.com/95f93fb96fd66efe1a1ac330265124f84069ab78 ========== to ========== [Mac/GN] Only specify a rpath for //chrome:chrome_helper_app in the component build. BUG=631833 R=erikchen@chromium.org Originally Committed: https://crrev.com/1905fc8c9e06650f75433a78e87e26477873da54 Reverted: https://crrev.com/95f93fb96fd66efe1a1ac330265124f84069ab78 ==========
Message was sent while issue was closed.
Description was changed from ========== [Mac/GN] Only specify a rpath for //chrome:chrome_helper_app in the component build. BUG=631833 R=erikchen@chromium.org Originally Committed: https://crrev.com/1905fc8c9e06650f75433a78e87e26477873da54 Reverted: https://crrev.com/95f93fb96fd66efe1a1ac330265124f84069ab78 ========== to ========== [Mac/GN] Only specify a rpath for //chrome:chrome_helper_app in the component build. BUG=631833 R=dpranke@chromium.org, erikchen@chromium.org Originally Committed: https://crrev.com/1905fc8c9e06650f75433a78e87e26477873da54 Reverted: https://crrev.com/95f93fb96fd66efe1a1ac330265124f84069ab78 Committed: https://crrev.com/4860c3320f6268f980e68cb73167f90acf10a8e7 Cr-Commit-Position: refs/heads/master@{#408126} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/4860c3320f6268f980e68cb73167f90acf10a8e7 Cr-Commit-Position: refs/heads/master@{#408126}
Message was sent while issue was closed.
Description was changed from ========== [Mac/GN] Only specify a rpath for //chrome:chrome_helper_app in the component build. BUG=631833 R=dpranke@chromium.org, erikchen@chromium.org Originally Committed: https://crrev.com/1905fc8c9e06650f75433a78e87e26477873da54 Reverted: https://crrev.com/95f93fb96fd66efe1a1ac330265124f84069ab78 Committed: https://crrev.com/4860c3320f6268f980e68cb73167f90acf10a8e7 Cr-Commit-Position: refs/heads/master@{#408126} ========== to ========== [Mac/GN] Only specify a rpath for //chrome:chrome_helper_app in the component build. BUG=631833 R=dpranke@chromium.org, erikchen@chromium.org Originally Committed: https://crrev.com/1905fc8c9e06650f75433a78e87e26477873da54 Reverted: https://crrev.com/95f93fb96fd66efe1a1ac330265124f84069ab78 Committed: https://chromium.googlesource.com/chromium/src/+/4860c3320f6268f980e68cb73167... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 4860c3320f6268f980e68cb73167f90acf10a8e7 (presubmit successful). |
