Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Unified Diff: chrome/BUILD.gn

Issue 2183963003: [Mac/GN] Only specify a rpath for //chrome:chrome_helper_app in the component build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix, reland Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/BUILD.gn
diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn
index 302a086e1eb49a00de7d82ea20e23bf0dad72de4..b4f53aeac8ea3b73665c19d59425a3c3f7eb2299 100644
--- a/chrome/BUILD.gn
+++ b/chrome/BUILD.gn
@@ -679,12 +679,16 @@ if (is_win) {
"//chrome/common:version_header",
]
- ldflags = [
- # The helper is in Chromium.app/Contents/Versions/X/Chromium Helper.app/Conents/MacOS/
- # so set rpath up to the base.
- "-rpath",
- "@loader_path/../../../../../../..",
- ]
+ ldflags = []
+
+ if (is_component_build) {
+ ldflags += [
+ # The helper is in Chromium.app/Contents/Versions/X/Chromium Helper.app/Conents/MacOS/
+ # so set rpath up to the base.
+ "-rpath",
+ "@loader_path/../../../../../../..",
+ ]
+ }
# Remove the default strip configuration (which strips all symbols) so that
# a saves file can be specified.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698