Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: chrome/BUILD.gn

Issue 2183963003: [Mac/GN] Only specify a rpath for //chrome:chrome_helper_app in the component build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix, reland Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/buildflag_header.gni") 5 import("//build/buildflag_header.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/compiler/compiler.gni") 7 import("//build/config/compiler/compiler.gni")
8 import("//build/config/features.gni") 8 import("//build/config/features.gni")
9 import("//build/config/locales.gni") 9 import("//build/config/locales.gni")
10 import("//build/config/sanitizers/sanitizers.gni") 10 import("//build/config/sanitizers/sanitizers.gni")
(...skipping 661 matching lines...) Expand 10 before | Expand all | Expand 10 after
672 ] 672 ]
673 673
674 extra_configs = [ "//build/config/compiler:wexit_time_destructors" ] 674 extra_configs = [ "//build/config/compiler:wexit_time_destructors" ]
675 675
676 defines = [ "HELPER_EXECUTABLE" ] 676 defines = [ "HELPER_EXECUTABLE" ]
677 677
678 deps = [ 678 deps = [
679 "//chrome/common:version_header", 679 "//chrome/common:version_header",
680 ] 680 ]
681 681
682 ldflags = [ 682 ldflags = []
683 # The helper is in Chromium.app/Contents/Versions/X/Chromium Helper.app/Co nents/MacOS/ 683
684 # so set rpath up to the base. 684 if (is_component_build) {
685 "-rpath", 685 ldflags += [
686 "@loader_path/../../../../../../..", 686 # The helper is in Chromium.app/Contents/Versions/X/Chromium Helper.app/ Conents/MacOS/
687 ] 687 # so set rpath up to the base.
688 "-rpath",
689 "@loader_path/../../../../../../..",
690 ]
691 }
688 692
689 # Remove the default strip configuration (which strips all symbols) so that 693 # Remove the default strip configuration (which strips all symbols) so that
690 # a saves file can be specified. 694 # a saves file can be specified.
691 if (enable_stripping) { 695 if (enable_stripping) {
692 remove_configs = [ "//build/config/mac:strip_all" ] 696 remove_configs = [ "//build/config/mac:strip_all" ]
693 697
694 ldflags += 698 ldflags +=
695 [ "-Wcrl,strip,-s," + rebase_path("app/app.saves", root_build_dir) ] 699 [ "-Wcrl,strip,-s," + rebase_path("app/app.saves", root_build_dir) ]
696 } 700 }
697 } 701 }
(...skipping 1130 matching lines...) Expand 10 before | Expand all | Expand 10 after
1828 "//chrome/app/theme/$branding_path_component/product_logo_48.png", 1832 "//chrome/app/theme/$branding_path_component/product_logo_48.png",
1829 "//chrome/tools/build/linux/chrome-wrapper", 1833 "//chrome/tools/build/linux/chrome-wrapper",
1830 "//third_party/xdg-utils/scripts/xdg-mime", 1834 "//third_party/xdg-utils/scripts/xdg-mime",
1831 "//third_party/xdg-utils/scripts/xdg-settings", 1835 "//third_party/xdg-utils/scripts/xdg-settings",
1832 ] 1836 ]
1833 outputs = [ 1837 outputs = [
1834 "$root_out_dir/{{source_file_part}}", 1838 "$root_out_dir/{{source_file_part}}",
1835 ] 1839 ]
1836 } 1840 }
1837 } 1841 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698