components/subresource_filter/content/renderer/subresource_filter_agent.cc - Issue 2183883002: Implement deactivating SubresourceFilter for document.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/subresource_filter/content/renderer/subresource_filter_agent.cc

Issue 2183883002: Implement deactivating SubresourceFilter for document. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@integrate_ruleset

Patch Set: Address more comments from engedy@ Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/subresource_filter/content/renderer/document_subresource_filter_unittest.cc ('k') | components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/subresource_filter/content/renderer/subresource_filter_agent.cc

diff --git a/components/subresource_filter/content/renderer/subresource_filter_agent.cc b/components/subresource_filter/content/renderer/subresource_filter_agent.cc

index a7c338db2804f23a6c76e0a32271de5ea0bb1f6d..0b2d452f41a42436b49c23032f4fa65b110c2481 100644

--- a/components/subresource_filter/content/renderer/subresource_filter_agent.cc

+++ b/components/subresource_filter/content/renderer/subresource_filter_agent.cc

@@ -66,6 +66,9 @@ void SubresourceFilterAgent::RecordHistogramsOnLoadCommitted() {

void SubresourceFilterAgent::RecordHistogramsOnLoadFinished() {

DCHECK(filter_for_last_committed_load_);

UMA_HISTOGRAM_COUNTS_1000(

+ "SubresourceFilter.DocumentLoad.NumSubresourceLoads.Total",

+ filter_for_last_committed_load_->num_loads_total());

+ UMA_HISTOGRAM_COUNTS_1000(

"SubresourceFilter.DocumentLoad.NumSubresourceLoads.Evaluated",

filter_for_last_committed_load_->num_loads_evaluated());

UMA_HISTOGRAM_COUNTS_1000(

@@ -95,7 +98,7 @@ void SubresourceFilterAgent::DidCommitProvisionalLoad(

std::unique_ptr<DocumentSubresourceFilter> filter(

new DocumentSubresourceFilter(activation_state_for_provisional_load_,

ruleset_dealer_->ruleset(),

- std::move(ancestor_document_urls)));

+ ancestor_document_urls));

filter_for_last_committed_load_ = filter->AsWeakPtr();

SetSubresourceFilterForCommittedLoad(std::move(filter));

}