components/subresource_filter/content/renderer/document_subresource_filter_unittest.cc - Issue 2183883002: Implement deactivating SubresourceFilter for document.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/subresource_filter/content/renderer/document_subresource_filter_unittest.cc

Issue 2183883002: Implement deactivating SubresourceFilter for document. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@integrate_ruleset

Patch Set: Address more comments from engedy@ Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/subresource_filter/content/renderer/document_subresource_filter.cc ('k') | components/subresource_filter/content/renderer/subresource_filter_agent.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/subresource_filter/content/renderer/document_subresource_filter_unittest.cc

diff --git a/components/subresource_filter/content/renderer/document_subresource_filter_unittest.cc b/components/subresource_filter/content/renderer/document_subresource_filter_unittest.cc

index deba5c3c85b7fdaabf8aee128d3ab0eb2c74d9cf..c02acb1006177f620d0ac58b8dd7764bf43e2d45 100644

--- a/components/subresource_filter/content/renderer/document_subresource_filter_unittest.cc

+++ b/components/subresource_filter/content/renderer/document_subresource_filter_unittest.cc

@@ -61,6 +61,7 @@ TEST_F(DocumentSubresourceFilterTest, DryRun) {

std::vector<GURL>());

EXPECT_TRUE(filter.allowLoad(GURL(kTestFirstURL), request_context));

EXPECT_TRUE(filter.allowLoad(GURL(kTestSecondURL), request_context));

+ EXPECT_EQ(2u, filter.num_loads_total());

EXPECT_EQ(2u, filter.num_loads_evaluated());

EXPECT_EQ(1u, filter.num_loads_matching_rules());

EXPECT_EQ(0u, filter.num_loads_disallowed());

@@ -73,6 +74,7 @@ TEST_F(DocumentSubresourceFilterTest, Enabled) {

std::vector<GURL>());

EXPECT_FALSE(filter.allowLoad(GURL(kTestFirstURL), request_context));

EXPECT_TRUE(filter.allowLoad(GURL(kTestSecondURL), request_context));

+ EXPECT_EQ(2u, filter.num_loads_total());

EXPECT_EQ(2u, filter.num_loads_evaluated());

EXPECT_EQ(1u, filter.num_loads_matching_rules());

EXPECT_EQ(1u, filter.num_loads_disallowed());